[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Review Request 115405: Always enable the "Create New..." menu if the URL is
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2014-01-30 18:33:19
Message-ID: 20140130183319.16031.27908 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115405/
-----------------------------------------------------------
Review request for Dolphin.
Bugs: 330001 and 330015
http://bugs.kde.org/show_bug.cgi?id=330001
http://bugs.kde.org/show_bug.cgi?id=330015
Repository: kde-baseapps
Description
-------
To find out if the current URL is writable or not, we wait for the KDirLister's \
completed() signal and then investigate its rootItem() via KFileItemListProperties.
This goes wrong if there is no "rootItem", which could be caused by a problem in the \
kioslave, see http://lists.kde.org/?l=kfm-devel&m=139015381308473&w=2
We got quite a few reports about smb since 4.12.0 (that might indicate that something \
broke in kio_smb recently) and also one report which does not seem to involve smb.
I propose to fix this problem by creating a KFileItem for the current URL and using \
that if we don't get a rootItem() from the dir lister. This is also the approach that \
Konqueror's context menu uses, BTW. It is my understanding though that the rootItem() \
approach can prevent that the GUI is blocked if the access to the URL is very slow \
because the access happens in the kioslave (an external process).
A real fix for the problem in the affected kioslaves might be better, but since we \
don't know if this will break again in other kioslaves in the future, I think that \
the workaround makes sense.
Diffs
-----
dolphin/src/views/dolphinview.cpp 303731c
Diff: https://git.reviewboard.kde.org/r/115405/diff/
Testing
-------
The "Create New..." menu is still enabled and disabled approprately for me, as \
before. A user who suffers from the bug tested the patch and confirmed that it fixes \
the problem for him.
Thanks,
Frank Reininghaus
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115405/">https://git.reviewboard.kde.org/r/115405/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330001">330001</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=330015">330015</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To find out if the current URL is writable or not, we wait for the \
KDirLister's completed() signal and then investigate its rootItem() via \
KFileItemListProperties.
This goes wrong if there is no "rootItem", which could be caused by a \
problem in the kioslave, see \
http://lists.kde.org/?l=kfm-devel&m=139015381308473&w=2
We got quite a few reports about smb since 4.12.0 (that might indicate that something \
broke in kio_smb recently) and also one report which does not seem to involve smb.
I propose to fix this problem by creating a KFileItem for the current URL and using \
that if we don't get a rootItem() from the dir lister. This is also the approach \
that Konqueror's context menu uses, BTW. It is my understanding though that the \
rootItem() approach can prevent that the GUI is blocked if the access to the URL is \
very slow because the access happens in the kioslave (an external process).
A real fix for the problem in the affected kioslaves might be better, but since we \
don't know if this will break again in other kioslaves in the future, I think \
that the workaround makes sense.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The "Create New..." menu is still enabled and disabled \
approprately for me, as before. A user who suffers from the bug tested the patch and \
confirmed that it fixes the problem for him.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(303731c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115405/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic