This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114812/

Review request for Dolphin.
By Emmanuel Pescosta.

Updated Jan. 30, 2014, 1:11 p.m.

Changes

* Removed dropbox/Messages.sh
* Small changes in FileViewDropboxPlugin::sendCommand
Bugs: 298199
Repository: dolphin-plugins

Description

Added a Dropbox version control plugin for Dolphin.

This Dropbox plugin is based on the work of:
Sergei Stolyarovs - https://bitbucket.org/cancel/dolphin-dropbox-plugin
Thomas Richards - http://trichard-kde.blogspot.co.at/2010/12/introducing-dropbox-integration-for.html

What I have done:
- Ported the old source code to the newer KVersionControlPlugin2 interface
- Use the Dropbox client to form the context menu more dynamically
  (If the Dropbox guys add a new feature to their client, Dolphin can make use of it automatically)
- Fixed a crash (Dolphin-4.8.2 segfaults when a file with special characters is present)
- Replaced the item version changed timer with a file system watcher -> No useless updates every 10 seconds and immediate update on real changes
- A lot of code/coding style related changes

I think that this plugin is small enough to include it into the official Dolphin-plugins collection. ;)

Testing

Works fine for me.

Diffs (updated)

  • dropbox/fileviewdropboxplugin.desktop (PRE-CREATION)
  • dropbox/fileviewdropboxplugin.h (PRE-CREATION)
  • dropbox/fileviewdropboxplugin.cpp (PRE-CREATION)
  • dropbox/CMakeLists.txt (PRE-CREATION)
  • CMakeLists.txt (4d87420)

View Diff