From kfm-devel Tue Jan 28 16:21:57 2014 From: "Yichao Zhou" Date: Tue, 28 Jan 2014 16:21:57 +0000 To: kfm-devel Subject: Re: Review Request 115357: Add a shortcut for copying current directory Message-Id: <20140128162157.791.29539 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kfm-devel&m=139092614016233 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1309497936127641408==" --===============1309497936127641408== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Jan. 28, 2014, 3:58 p.m., Frank Reininghaus wrote: > > First of all, thanks for the patch! > > > > To quote my comment https://bugs.kde.org/show_bug.cgi?id=323960#c3 : > > > > "...this is one of the cases where I wonder if this feature is really useful enough that it justifies adding code which must be maintained in the future, and adding another action that makes the shortcuts dialog harder to use (I admit that it's a big mess not not very useable already)." > > Frank Reininghaus wrote: > Hm, I shouldn't have copied the typo from the comment ("not not" -> "and not"): > > "...this is one of the cases where I wonder if this feature is really useful enough that it justifies adding code which must be maintained in the future, and adding another action that makes the shortcuts dialog harder to use (I admit that it's a big mess and not very useable already)." Well. I really like this feature... IMHO, adding 2 more actions really will not make shortcuts dialog much harder to use. See, we already have had more than 70 actions there. Add 2 extra options will at most cost us about 3% increase of entropy even if they are totally useless. For the maintenance overhead, this patch only adds 70 lines of code, most of which is the declaration. I think it is unlikely that any part of it will be modified in the future. Anyway. I think that's all what I can do. If main developers really do not will to merge it, let's just leave it here. - Yichao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115357/#review48484 ----------------------------------------------------------- On Jan. 28, 2014, 3:55 p.m., Yichao Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115357/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 3:55 p.m.) > > > Review request for Dolphin. > > > Bugs: 323960 > http://bugs.kde.org/show_bug.cgi?id=323960 > > > Repository: kde-baseapps > > > Description > ------- > > Add 2 shortcuts as described in > https://bugs.kde.org/show_bug.cgi?id=323960 > > 1. Copy current URL to Clipboard > Default Shortcut: Ctrl-Alt-C > > 2. Set current Url to the one in Clipboard > Default Shortcut: Ctrl-Alt-D (Because Ctrl-Alt-V is occupied by Klipper, D could be understood as "dispatch" maybe.. > > > Diffs > ----- > > dolphin/src/dolphinmainwindow.h 6b046c2 > dolphin/src/dolphinmainwindow.cpp a4dbb6f > > Diff: https://git.reviewboard.kde.org/r/115357/diff/ > > > Testing > ------- > > > Thanks, > > Yichao Zhou > > --===============1309497936127641408== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115357/

On January 28th, 2014, 3:58 p.m. UTC, Frank Reininghaus wrote:

First of all, thanks for the patch!

To quote my comment https://bugs.kde.org/show_bug.cgi?id=323960#c3 :

"...this is one of the cases where I wonder if this feature is really useful enough that it justifies adding code which must be maintained in the future, and adding another action that makes the shortcuts dialog harder to use (I admit that it's a big mess not not very useable already)."

On January 28th, 2014, 4:03 p.m. UTC, Frank Reininghaus wrote:

Hm, I shouldn't have copied the typo from the comment ("not not" -> "and not"):

"...this is one of the cases where I wonder if this feature is really useful enough that it justifies adding code which must be maintained in the future, and adding another action that makes the shortcuts dialog harder to use (I admit that it's a big mess and not very useable already)."
Well.  I really like this feature...

IMHO, adding 2 more actions really will not make shortcuts dialog much harder to use.  See, we already have had more than 70 actions there.  Add 2 extra options will at most cost us about 3% increase of entropy even if they are totally useless.

For the maintenance overhead, this patch only adds 70 lines of code, most of which is the declaration.  I think it is unlikely that any part of it will be modified in the future.

Anyway.  I think that's all what I can do.  If main developers really do not will to merge it, let's just leave it here.

- Yichao


On January 28th, 2014, 3:55 p.m. UTC, Yichao Zhou wrote:

Review request for Dolphin.
By Yichao Zhou.

Updated Jan. 28, 2014, 3:55 p.m.

Bugs: 323960
Repository: kde-baseapps

Description 

Add 2 shortcuts as described in
https://bugs.kde.org/show_bug.cgi?id=323960

1. Copy current URL to Clipboard
  Default Shortcut: Ctrl-Alt-C

2. Set current Url to the one in Clipboard
  Default Shortcut: Ctrl-Alt-D (Because Ctrl-Alt-V is occupied by Klipper, D could be understood as "dispatch" maybe..

Diffs

  • dolphin/src/dolphinmainwindow.h (6b046c2)
  • dolphin/src/dolphinmainwindow.cpp (a4dbb6f)

View Diff
--===============1309497936127641408==--