[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 115357: Add a shortcut for copying current directory
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2014-01-28 16:03:51
Message-ID: 20140128160351.11809.69485 () probe ! kde ! org
[Download RAW message or body]
> On Jan. 28, 2014, 3:58 p.m., Frank Reininghaus wrote:
> > First of all, thanks for the patch!
> >
> > To quote my comment https://bugs.kde.org/show_bug.cgi?id=323960#c3 :
> >
> > "...this is one of the cases where I wonder if this feature is really useful \
> > enough that it justifies adding code which must be maintained in the future, and \
> > adding another action that makes the shortcuts dialog harder to use (I admit that \
> > it's a big mess not not very useable already)."
Hm, I shouldn't have copied the typo from the comment ("not not" -> "and not"):
"...this is one of the cases where I wonder if this feature is really useful enough \
that it justifies adding code which must be maintained in the future, and adding \
another action that makes the shortcuts dialog harder to use (I admit that it's a big \
mess and not very useable already)."
- Frank
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115357/#review48484
-----------------------------------------------------------
On Jan. 28, 2014, 3:55 p.m., Yichao Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115357/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 3:55 p.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 323960
> http://bugs.kde.org/show_bug.cgi?id=323960
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Add 2 shortcuts as described in
> https://bugs.kde.org/show_bug.cgi?id=323960
>
> 1. Copy current URL to Clipboard
> Default Shortcut: Ctrl-Alt-C
>
> 2. Set current Url to the one in Clipboard
> Default Shortcut: Ctrl-Alt-D (Because Ctrl-Alt-V is occupied by Klipper, D could be \
> understood as "dispatch" maybe..
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 6b046c2
> dolphin/src/dolphinmainwindow.cpp a4dbb6f
>
> Diff: https://git.reviewboard.kde.org/r/115357/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yichao Zhou
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115357/">https://git.reviewboard.kde.org/r/115357/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 28th, 2014, 3:58 p.m. UTC, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First of all, thanks for the patch!
To quote my comment https://bugs.kde.org/show_bug.cgi?id=323960#c3 :
"...this is one of the cases where I wonder if this feature is really useful \
enough that it justifies adding code which must be maintained in the future, and \
adding another action that makes the shortcuts dialog harder to use (I admit that \
it's a big mess not not very useable already)."</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, I shouldn't have \
copied the typo from the comment ("not not" -> "and not"):
"...this is one of the cases where I wonder if this feature is really useful \
enough that it justifies adding code which must be maintained in the future, and \
adding another action that makes the shortcuts dialog harder to use (I admit that \
it's a big mess and not very useable already)."</pre> <br />
<p>- Frank</p>
<br />
<p>On January 28th, 2014, 3:55 p.m. UTC, Yichao Zhou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Yichao Zhou.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2014, 3:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323960">323960</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add 2 shortcuts as described in \
https://bugs.kde.org/show_bug.cgi?id=323960
1. Copy current URL to Clipboard
Default Shortcut: Ctrl-Alt-C
2. Set current Url to the one in Clipboard
Default Shortcut: Ctrl-Alt-D (Because Ctrl-Alt-V is occupied by Klipper, D could be \
understood as "dispatch" maybe..</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(6b046c2)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(a4dbb6f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115357/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic