[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 115064: Use only one "directory contents counting" thread per process
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2014-01-21 18:11:37
Message-ID: 20140121181137.17756.27088 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115064/
-----------------------------------------------------------
(Updated Jan. 21, 2014, 6:11 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin.
Repository: kde-baseapps
Description
-------
Since https://git.reviewboard.kde.org/r/111920/, we use a separate thread \
for counting the items inside directories (e.g., for the "Size" column in \
Details View) to prevent that the GUI is blocked while handling large \
directories. However, this means that Dolphin now uses quite a lot of \
threads if there are many views. To see that, run Dolphin in gdb, open many \
tabs with Ctrl+T, and check the output of "thread apply all backtrace.
I propose to make all views share the same thread. The QThread object is \
stored in a global variable, and each view increments/decrements a \
reference count when it starts/stops using the thread. If this thread \
reaches zero, the thread is stopped.
Diffs
-----
dolphin/src/kitemviews/private/kdirectorycontentscounter.h 425c363
dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp fd8479f
Diff: https://git.reviewboard.kde.org/r/115064/diff/
Testing
-------
Opening new views does not start new threads any more. The "Size" column in \
Details view still works normally for me.
Thanks,
Frank Reininghaus
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115064/">https://git.reviewboard.kde.org/r/115064/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2014, 6:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since https://git.reviewboard.kde.org/r/111920/, we use a \
separate thread for counting the items inside directories (e.g., for the \
"Size" column in Details View) to prevent that the GUI is blocked \
while handling large directories. However, this means that Dolphin now uses \
quite a lot of threads if there are many views. To see that, run Dolphin in \
gdb, open many tabs with Ctrl+T, and check the output of "thread apply \
all backtrace.
I propose to make all views share the same thread. The QThread object is \
stored in a global variable, and each view increments/decrements a \
reference count when it starts/stops using the thread. If this thread \
reaches zero, the thread is stopped.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Opening new views does not start new threads any more. The \
"Size" column in Details view still works normally for me.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/private/kdirectorycontentscounter.h <span \
style="color: grey">(425c363)</span></li>
<li>dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp <span \
style="color: grey">(fd8479f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115064/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic