[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 113957: Rename of "Recently Accessed" to "Recently Saved"
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2013-12-14 13:35:29
Message-ID: CAH3KK-Vnotq2nM7E7uv6A1v6MgbC7YsAroVUFAfVkdUKy5_Z4A () mail ! gmail ! com
[Download RAW message or body]
> Does this mean I have to compile things? Actually I don't know how to do
> this.
It's really easy ;)
The steps are:
1. Create a folder structure were you have your source code, your build
directory and your install directory.
For example:
mkdir $HOME/kde-devel
cd $HOME/kde-devel
mkdir src build install
2. Clone the repos into $HOME/kde-devel/src
For example:
cd $HOME/kde-devel/src
git clone kde:kde-baseapps
3. Open KDevelop and Open/Import this project
4. Use $HOME/kde-devel/install as intall directory and
$HOME/kde-devel/build as build directory.
5. Edit the source code/apply patches and build the project
6. Run -> Configure Launches and add Dolphin here
7. Start Dolphin via execute
8. Have fun! ;)
2013/12/14 Frank Reininghaus <frank78ac@googlemail.com>
> Hi,
>
> it's actually preferred to add additional comments to the review
> request directly. Splitting the conversation between the review
> request and regular mails makes the conversation hard to follow for
> anyone who might try to find out something about it in the future.
>
> 2013/12/11 Richard llom:
> > Frank Reininghaus wrote:
> >
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> http://git.reviewboard.kde.org/r/113957/#review45525
> >> -----------------------------------------------------------
> >>
> >> Ship it!
> >>
> >>
> >> Looks good, thanks! Do you have a git account?
> >>
> > I don't know, so far I accomplished everything with the identity.kde.org
> > account. Does this include a git account?
>
> No. We can push the patch for you then.
>
> >> If yes, feel free to push to master once you have tested that it still
> >> works as expected, i.e., that the change does not cause unexpected
> >> breakage at run time.
> >>
> > Does this mean I have to compile things? Actually I don't know how to do
> > this.
>
> Does that mean that you did not even check if the patched code still
> builds? I'm a bit surprised now - actually, I think that everyone
> assumes implicitly that at least this has been verified for *every*
> patch uploaded to ReviewBoard, unless explicitly stated otherwise.
>
> Actually, I think that I clearly stated in
>
> https://bugs.kde.org/show_bug.cgi?id=304854#c7
>
> that the reason why I would appreciate help with this change is that
> careful testing of the change is IMHO needed (it might seem unlikely
> that it breaks at runtime, but one should definitely test it in order
> not to cause unexptected trouble).
>
> But I hope that I misunderstood you ;-)
>
> Cheers,
> Frank
>
[Attachment #3 (text/html)]
<div dir="ltr"><div><div><div><div>> Does this mean I have to compile things? \
Actually I don't know how to do<br> > this.<br><br></div>It's really easy \
;)<br><br></div><div>The steps are:<br></div><div>1. Create a folder structure were \
you have your source code, your build directory and your install \
directory.<br></div><div> For example: <br> </div><div> mkdir \
$HOME/kde-devel<br></div><div> cd $HOME/kde-devel<br></div><div> \
mkdir src build install</div><div><br></div><div>2. Clone the repos into \
$HOME/kde-devel/src <br></div><div> For example:<br> </div><div> cd \
$HOME/kde-devel/src <br></div><div> git clone \
kde:kde-baseapps<br><br></div><div>3. Open KDevelop and Open/Import this \
project<br><br></div><div>4. Use $HOME/kde-devel/install as intall directory and<br> \
$HOME/kde-devel/build as build directory.<br><br></div><div>5. Edit the source \
code/apply patches and build the project<br><br></div><div>6. Run -> Configure \
Launches and add Dolphin here<br><br></div><div>7. Start Dolphin via execute<br> \
<br></div><div>8. Have fun! ;)<br></div></div></div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">2013/12/14 Frank Reininghaus \
<span dir="ltr"><<a href="mailto:frank78ac@googlemail.com" \
target="_blank">frank78ac@googlemail.com</a>></span><br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi,<br> <br>
it's actually preferred to add additional comments to the review<br>
request directly. Splitting the conversation between the review<br>
request and regular mails makes the conversation hard to follow for<br>
anyone who might try to find out something about it in the future.<br>
<br>
2013/12/11 Richard llom:<br>
<div class="im">> Frank Reininghaus wrote:<br>
><br>
>> -----------------------------------------------------------<br>
>> This is an automatically generated e-mail. To reply, visit:<br>
>> <a href="http://git.reviewboard.kde.org/r/113957/#review45525" \
target="_blank">http://git.reviewboard.kde.org/r/113957/#review45525</a><br> >> \
-----------------------------------------------------------<br> >><br>
>> Ship it!<br>
>><br>
>><br>
>> Looks good, thanks! Do you have a git account?<br>
>><br>
> I don't know, so far I accomplished everything with the <a \
href="http://identity.kde.org" target="_blank">identity.kde.org</a><br> > account. \
Does this include a git account?<br> <br>
</div>No. We can push the patch for you then.<br>
<div class="im"><br>
>> If yes, feel free to push to master once you have tested that it still<br>
>> works as expected, i.e., that the change does not cause unexpected<br>
>> breakage at run time.<br>
>><br>
> Does this mean I have to compile things? Actually I don't know how to do<br>
> this.<br>
<br>
</div>Does that mean that you did not even check if the patched code still<br>
builds? I'm a bit surprised now - actually, I think that everyone<br>
assumes implicitly that at least this has been verified for *every*<br>
patch uploaded to ReviewBoard, unless explicitly stated otherwise.<br>
<br>
Actually, I think that I clearly stated in<br>
<br>
<a href="https://bugs.kde.org/show_bug.cgi?id=304854#c7" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=304854#c7</a><br> <br>
that the reason why I would appreciate help with this change is that<br>
careful testing of the change is IMHO needed (it might seem unlikely<br>
that it breaks at runtime, but one should definitely test it in order<br>
not to cause unexptected trouble).<br>
<br>
But I hope that I misunderstood you ;-)<br>
<br>
Cheers,<br>
Frank<br>
</blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic