[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 113930: Make the "Create New..." menu in the "item context menu" work again
From: "Commit Hook" <null () kde ! org>
Date: 2013-11-20 23:43:52
Message-ID: 20131120234352.25835.81495 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113930/#review44078
-----------------------------------------------------------
This review has been submitted with commit 2736d24f98c2880713264250c42bc0309e86e8b9 \
by Frank Reininghaus to branch KDE/4.12.
- Commit Hook
On Nov. 18, 2013, 11:09 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113930/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:09 p.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 327783
> http://bugs.kde.org/show_bug.cgi?id=327783
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Since https://git.reviewboard.kde.org/r/111989/, the "Create New..." menu in the \
> context menu that appears when right-clicking a folder is not a child of the \
> DolphinMainWindow any more, but of the context menu itself. This seems to be the \
> reason why the dialog that asks for a file name when choosing one of the "Create \
> New..." options disappears immediately.
> This patch makes sure that the main window is the parent of the "Create New..." \
> menu again.
>
> Diffs
> -----
>
> dolphin/src/dolphincontextmenu.cpp 7d11c3b
>
> Diff: http://git.reviewboard.kde.org/r/113930/diff/
>
>
> Testing
> -------
>
> Fixes the problem for me.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113930/">http://git.reviewboard.kde.org/r/113930/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 2736d24f98c2880713264250c42bc0309e86e8b9 by Frank Reininghaus \
to branch KDE/4.12.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On November 18th, 2013, 11:09 p.m. UTC, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2013, 11:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327783">327783</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since https://git.reviewboard.kde.org/r/111989/, the "Create \
New..." menu in the context menu that appears when right-clicking a folder is \
not a child of the DolphinMainWindow any more, but of the context menu itself. This \
seems to be the reason why the dialog that asks for a file name when choosing one of \
the "Create New..." options disappears immediately.
This patch makes sure that the main window is the parent of the "Create \
New..." menu again.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the problem for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(7d11c3b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113930/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic