[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 113939: Update the geometries of the viewport and the
From: "Yichao Yu" <yyc1992 () gmail ! com>
Date: 2013-11-19 15:48:34
Message-ID: 20131119154834.22583.79214 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113939/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 3:48 p.m.)
Review request for Dolphin, Frank Reininghaus and Peter Penz.
Changes
-------
(Copy-and-paste...) Backtrace is not attached to the review.....
Bugs: 327709
http://bugs.kde.org/show_bug.cgi?id=327709
Repository: kde-baseapps
Description (updated)
-------
When resizing the window and when `KItemListContainer::updateGeometries` is called \
before the scrollbar visibility is updated, a relayout is triggered in \
`m_controller->view()->setGeometry` which updates the scrollbar visibility and calls \
back to `KItemListContainer::updateGeometries` again. Since the first call, which has \
the wrong geometry (due to the incorrect scrollbar states), updates the geometries of \
the scene and viewport after the second call (which has the right geometry!!) \
returns, the final result is a size corresponds to old scrollbar state.
This patch uses the new geometry of the view after updating it (since it might not be \
the size we put in) and therefore makes the sizes consistent.
Diffs
-----
dolphin/src/kitemviews/kitemlistcontainer.cpp cd2fca1
Diff: http://git.reviewboard.kde.org/r/113939/diff/
Testing
-------
Compiles, solves the problem here.
Thanks,
Yichao Yu
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113939/">http://git.reviewboard.kde.org/r/113939/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, Frank Reininghaus and Peter Penz.</div>
<div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated Nov. 19, 2013, 3:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">(Copy-and-paste...) Backtrace is not attached to the review..... </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327709">327709</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When resizing the window and when `KItemListContainer::updateGeometries` \
is called before the scrollbar visibility is updated, a relayout is triggered in \
`m_controller->view()->setGeometry` which updates the scrollbar visibility and \
calls back to `KItemListContainer::updateGeometries` again. Since the first call, \
which has the wrong geometry (due to the incorrect scrollbar states), updates the \
geometries of the scene and viewport after the second call (which has the right \
geometry!!) returns, the final result is a size corresponds to old scrollbar state.
This patch uses the new geometry of the view after updating it (since it might not be \
the size we put in) and therefore makes the sizes consistent. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, solves the problem here. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kitemlistcontainer.cpp <span style="color: \
grey">(cd2fca1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113939/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic