--===============0305599359965436846== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113939/ ----------------------------------------------------------- Review request for Dolphin, Frank Reininghaus and Peter Penz. Bugs: 327709 http://bugs.kde.org/show_bug.cgi?id=327709 Repository: kde-baseapps Description ------- When resizing the window and when `KItemListContainer::updateGeometries` is called before the scrollbar visibility is updated, a relayout is triggered in `m_controller->view()->setGeometry` (bt attached) which updates the scrollbar visibility and calls back to `KItemListContainer::updateGeometries` again. Since the first call, which has the wrong geometry (due to the incorrect scrollbar states), updates the geometries of the scene and viewport after the second call (which has the right geometry!!) returns, the final result is a size corresponds to old scrollbar state. This patch uses the new geometry of the view after updating it (since it might not be the size we put in) and therefore makes the sizes consistent. Diffs ----- dolphin/src/kitemviews/kitemlistcontainer.cpp cd2fca1 Diff: http://git.reviewboard.kde.org/r/113939/diff/ Testing ------- Compiles, solves the problem here. Thanks, Yichao Yu --===============0305599359965436846== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113939/

Review request for Dolphin, Frank Reininghaus and Peter Penz.

By Yichao Yu.

Bugs: 327709

Repository: kde-baseapps

Description

When resizing the window and when `KItemListContainer::updateGeometries` is called before the scrollbar visibility is updated, a relayout is triggered in `m_controller->view()->setGeometry` (bt attached) which updates the scrollbar visibility and calls back to `KItemListContainer::updateGeometries` again. Since the first call, which has the wrong geometry (due to the incorrect scrollbar states), updates the geometries of the scene and viewport after the second call (which has the right geometry!!) returns, the final result is a size corresponds to old scrollbar state.

This patch uses the new geometry of the view after updating it (since it might not be the size we put in) and therefore makes the sizes consistent.

Testing

Compiles, solves the problem here.

Diffs

dolphin/src/kitemviews/kitemlistcontainer.cpp (cd2fca1)

--===============0305599359965436846==--