[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 113902: Fix scrollbar spacing when no scrollbar is visible in dolphin.
From:       "Yichao Yu" <yyc1992 () gmail ! com>
Date:       2013-11-18 22:44:30
Message-ID: 20131118224430.1530.35076 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113902/
-----------------------------------------------------------

(Updated Nov. 18, 2013, 10:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin, Frank Reininghaus and Peter Penz.


Bugs: 306631
    http://bugs.kde.org/show_bug.cgi?id=306631


Repository: kde-baseapps


Description
-------

Dolphin reserve space for scrollbar spacing even when no scrollbar is visible \
resulting in a ugly gap in the view when: 1. the theme uses \
QStyle::SH_ScrollView_FrameOnlyAroundContents and 2. the theme has a positive \
PM_ScrollView_ScrollBarSpacing.

QtCurve can have both while Oxygen have 1 but not 2.
To reproduce the problem with Oxygen style. Replace the `width += ....` (which \
returns -2 or 0 for Oxygen) with `width += 2`.

See more info here[1].

[1] https://github.com/QtCurve/qtcurve-qt4/issues/9#issuecomment-28630517


Diffs
-----

  dolphin/src/kitemviews/kitemlistcontainer.cpp f2e94b7 

Diff: http://git.reviewboard.kde.org/r/113902/diff/


Testing
-------

Logic looks right.
Compiled and it fixes the problem.


Thanks,

Yichao Yu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113902/">http://git.reviewboard.kde.org/r/113902/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Dolphin, Frank Reininghaus and Peter Penz.</div>
<div>By Yichao Yu.</div>


<p style="color: grey;"><i>Updated Nov. 18, 2013, 10:44 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=306631">306631</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Dolphin reserve space for scrollbar spacing even when no scrollbar is \
visible resulting in a ugly gap in the view when: 1. the theme uses \
QStyle::SH_ScrollView_FrameOnlyAroundContents and 2. the theme has a positive \
PM_ScrollView_ScrollBarSpacing.

QtCurve can have both while Oxygen have 1 but not 2.
To reproduce the problem with Oxygen style. Replace the `width += ....` (which \
returns -2 or 0 for Oxygen) with `width += 2`.

See more info here[1].

[1] https://github.com/QtCurve/qtcurve-qt4/issues/9#issuecomment-28630517
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Logic looks right. Compiled and it fixes the problem.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/kitemviews/kitemlistcontainer.cpp <span style="color: \
grey">(f2e94b7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113902/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic