[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 113101: Fix Bug 287983 - Dolphin truncates tooltip information for long file name
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2013-11-02 13:33:12
Message-ID: 20131102133312.12837.71700 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 16, 2013, 9:16 p.m., Frank Reininghaus wrote:
> > I think that it looks good now, thanks!
> >
> > Kai (or anyone else with good font rendering knowledge), is there anything else \
> > that needs to be taken into account?
m_name->setMaximumWidth(fontMetrics.averageCharWidth() * 40);
looks fine to me. Thanks!
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113101/#review41841
-----------------------------------------------------------
On Nov. 1, 2013, 11:15 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113101/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 11:15 p.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 287983
> http://bugs.kde.org/show_bug.cgi?id=287983
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Use KStringHandler and QTextLayout to wrap the text (file name)
> into the maximum width of the label "name".
>
>
> Diffs
> -----
>
> dolphin/src/views/tooltips/filemetadatatooltip.cpp c22f6be
>
> Diff: http://git.reviewboard.kde.org/r/113101/diff/
>
>
> Testing
> -------
>
> Works
>
>
> File Attachments
> ----------------
>
> Tooltip Widget with a long file name - Dolphin 4.11.2
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/b5e3213b-ca9b-4abc-b2b7-1f62f8748521__snapshot11.png
> Tooltip Widget with a long file name - Dolphin 4.11.3 (Patched)
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/26a7063d-ad96-4a8d-a0b2-fc0414ab1304__snapshot12.png
> Patched version + normal font size
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/1ba52037-d951-48eb-8e39-862d88ffc85e__snapshot13.png
> Patched version + big font size
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/7b984cc1-274b-4982-8712-7638e3c0b72c__snapshot14.png
> 200dpi
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/6560bcd6-4475-4af0-97b5-76c9682f1368__snapshot15.png
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113101/">http://git.reviewboard.kde.org/r/113101/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 16th, 2013, 9:16 p.m. UTC, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think that it looks good now, thanks!
Kai (or anyone else with good font rendering knowledge), is there anything else that \
needs to be taken into account?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">m_name->setMaximumWidth(fontMetrics.averageCharWidth() * 40); looks \
fine to me. Thanks!</pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On November 1st, 2013, 11:15 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2013, 11:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287983">287983</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use KStringHandler and QTextLayout to wrap the text (file name) into the \
maximum width of the label "name".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/tooltips/filemetadatatooltip.cpp <span style="color: \
grey">(c22f6be)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113101/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/b5e3213b-ca9b-4abc-b2b7-1f62f8748521__snapshot11.png">Tooltip \
Widget with a long file name - Dolphin 4.11.2</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/26a7063d-ad96-4a8d-a0b2-fc0414ab1304__snapshot12.png">Tooltip \
Widget with a long file name - Dolphin 4.11.3 (Patched)</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/1ba52037-d951-48eb-8e39-862d88ffc85e__snapshot13.png">Patched \
version + normal font size</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/7b984cc1-274b-4982-8712-7638e3c0b72c__snapshot14.png">Patched \
version + big font size</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/6560bcd6-4475-4af0-97b5-76c9682f1368__snapshot15.png">200dpi</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic