[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 113290: Fix for broken view state restoration (recent regression in KDE/4.11 bran
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2013-10-25 11:49:25
Message-ID: 20131025114925.5318.6394 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113290/#review42351
-----------------------------------------------------------
Ship it!
Ship It!
- Emmanuel Pescosta
On Oct. 16, 2013, 10:36 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113290/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 10:36 p.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 326039
> http://bugs.kde.org/show_bug.cgi?id=326039
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> The fix for bug 161385 (which was about Dolphin still showing an empty view if a \
> device that had been unmounted earlier was clicked in the Places Panel) caused a \
> regression: the view state (current item, scroll position, Details View expansion \
> state) is not restored any more when going "Back".
> The reason is that "m_view->reload()" in DolphinViewContainer::setUrl(const KUrl& \
> newUrl) is now always executed just after entering a directory, and that command \
> overwrites this information.
> Distinguishing between "change URL" and "reload the view" works better if it's done \
> in DolphinMainWindow instead of DolphinViewContainer.
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 7da5801
> dolphin/src/dolphinmainwindow.cpp ccef356
> dolphin/src/dolphinviewcontainer.cpp c8fc757
>
> Diff: http://git.reviewboard.kde.org/r/113290/diff/
>
>
> Testing
> -------
>
> Fixes the bug, and I verified that the new approach also fixes bug 161385.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113290/">http://git.reviewboard.kde.org/r/113290/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On October 16th, 2013, 10:36 p.m. CEST, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2013, 10:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326039">326039</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The fix for bug 161385 (which was about Dolphin still showing an empty \
view if a device that had been unmounted earlier was clicked in the Places Panel) \
caused a regression: the view state (current item, scroll position, Details View \
expansion state) is not restored any more when going "Back".
The reason is that "m_view->reload()" in \
DolphinViewContainer::setUrl(const KUrl& newUrl) is now always executed just \
after entering a directory, and that command overwrites this information.
Distinguishing between "change URL" and "reload the view" works \
better if it's done in DolphinMainWindow instead of DolphinViewContainer.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the bug, and I verified that the new approach also fixes bug \
161385.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7da5801)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(ccef356)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(c8fc757)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113290/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic