From kfm-devel Wed Oct 16 21:16:13 2013 From: "Frank Reininghaus" Date: Wed, 16 Oct 2013 21:16:13 +0000 To: kfm-devel Subject: Re: Review Request 113101: Fix Bug 287983 - Dolphin truncates tooltip information for long file name Message-Id: <20131016211613.30271.555 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=138195818616196 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4097200548365940645==" --===============4097200548365940645== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113101/#review41841 ----------------------------------------------------------- I think that it looks good now, thanks! Kai (or anyone else with good font rendering knowledge), is there anything else that needs to be taken into account? - Frank Reininghaus On Oct. 15, 2013, 11:11 a.m., Emmanuel Pescosta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113101/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2013, 11:11 a.m.) > > > Review request for Dolphin. > > > Bugs: 287983 > http://bugs.kde.org/show_bug.cgi?id=287983 > > > Repository: kde-baseapps > > > Description > ------- > > Use KStringHandler and QTextLayout to wrap the text (file name) > into the maximum width of the label "name". > > > Diffs > ----- > > dolphin/src/views/tooltips/filemetadatatooltip.cpp c22f6be > > Diff: http://git.reviewboard.kde.org/r/113101/diff/ > > > Testing > ------- > > Works > > > File Attachments > ---------------- > > Tooltip Widget with a long file name - Dolphin 4.11.2 > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/b5e3213b-ca9b-4abc-b2b7-1f62f8748521__snapshot11.png > Tooltip Widget with a long file name - Dolphin 4.11.3 (Patched) > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/26a7063d-ad96-4a8d-a0b2-fc0414ab1304__snapshot12.png > Patched version + normal font size > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/1ba52037-d951-48eb-8e39-862d88ffc85e__snapshot13.png > Patched version + big font size > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/7b984cc1-274b-4982-8712-7638e3c0b72c__snapshot14.png > 200dpi > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/6560bcd6-4475-4af0-97b5-76c9682f1368__snapshot15.png > > > Thanks, > > Emmanuel Pescosta > > --===============4097200548365940645== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113101/

I think that it looks good now, thanks!

Kai (or anyone else with good font rendering knowledge), is there anything else that needs to be taken into account?

- Frank Reininghaus

On October 15th, 2013, 11:11 a.m. UTC, Emmanuel Pescosta wrote:

Review request for Dolphin.

By Emmanuel Pescosta.

Updated Oct. 15, 2013, 11:11 a.m.

Bugs: 287983

Repository: kde-baseapps

Description

Use KStringHandler and QTextLayout to wrap the text (file name)
into the maximum width of the label "name".

Testing

Works

Diffs

dolphin/src/views/tooltips/filemetadatatooltip.cpp (c22f6be)

View Diff

File Attachments

--===============4097200548365940645==--