'Re: Review Request 112962: Make sure that KFileItemModel::removeExpandedItems() also expands filtere'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 112962: Make sure that KFileItemModel::removeExpandedItems() also expands filtere
From:       "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date:       2013-09-28 18:33:08
Message-ID: 20130928183308.26665.57644 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112962/#review40963
-----------------------------------------------------------

Ship it!


Sry for the late response, but I was very busy for the last two weeks because I
moved to a new flat in another town - closer to Brno 2014 :)

Great and works fine!

- Emmanuel Pescosta


On Sept. 26, 2013, 9:09 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112962/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 9:09 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> I just noticed that KFileItemModel::removeExpandedItems() fails to remove expanded \
> items that are currently filtered, which can make expanded items re-appear \
> incorrectly after switching from Details to Icons View. 
> The fix is quite straightforward - just iterate over the filtered items and remove \
> those which have a parent. 
> 
> This addresses bug 325344.
> http://bugs.kde.org/show_bug.cgi?id=325344
> 
> 
> Diffs
> -----
> 
> dolphin/src/kitemviews/kfileitemmodel.cpp b6b6ee0 
> dolphin/src/tests/kfileitemmodeltest.cpp 391fe5b 
> 
> Diff: http://git.reviewboard.kde.org/r/112962/diff/
> 
> 
> Testing
> -------
> 
> Fixes the bug for me. Old and new unit tests pass.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112962/">http://git.reviewboard.kde.org/r/112962/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sry for the late \
response, but I was very busy for the last two weeks because I moved to a new flat in \
another town - closer to Brno 2014 :)

Great and works fine!</pre>
 <br />









<p>- Emmanuel</p>


<br />
<p>On September 26th, 2013, 9:09 p.m. UTC, Frank Reininghaus wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>


<p style="color: grey;"><i>Updated Sept. 26, 2013, 9:09 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I just noticed that KFileItemModel::removeExpandedItems() fails to \
remove expanded items that are currently filtered, which can make expanded items \
re-appear incorrectly after switching from Details to Icons View.

The fix is quite straightforward - just iterate over the filtered items and remove \
those which have a parent.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the bug for me. Old and new unit tests pass.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=325344">325344</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(b6b6ee0)</span></li>

 <li>dolphin/src/tests/kfileitemmodeltest.cpp <span style="color: \
grey">(391fe5b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112962/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic