This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112962/

Review request for Dolphin.
By Frank Reininghaus.

Description

I just noticed that KFileItemModel::removeExpandedItems() fails to remove expanded items that are currently filtered, which can make expanded items re-appear incorrectly after switching from Details to Icons View.

The fix is quite straightforward - just iterate over the filtered items and remove those which have a parent.

Testing

Fixes the bug for me. Old and new unit tests pass.
Bugs: 325344

Diffs

  • dolphin/src/kitemviews/kfileitemmodel.cpp (b6b6ee0)
  • dolphin/src/tests/kfileitemmodeltest.cpp (391fe5b)

View Diff