[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: UDSEntry compression ideas
From: Mark <markg85 () gmail ! com>
Date: 2013-09-21 13:47:54
Message-ID: CAPd6JnHB=OHS7rtfLAY_CaooxbaQBjJvxZ4KMromyivH+N2FkA () mail ! gmail ! com
[Download RAW message or body]
compile and run tested on frameworks. Also OK. I actually had one symlinked
file (kdesrc-build) which still shows up as that dummy symlink which is as
expected if i follow the code.
On Sat, Sep 21, 2013 at 3:45 PM, Mark <markg85@gmail.com> wrote:
> On Sat, Sep 21, 2013 at 10:59 AM, David Faure <faure@kde.org> wrote:
>
>> On Thursday 19 September 2013 23:13:04 Mark wrote:
>> > If i set details to 0 i'm welcomed by a "UDSEntry::UDS_LINK_DEST" that
>> > always seems to be: "Dummy Link Target".
>> > When i don't set details (which means details is 2) then i don't have a
>> > "UDSEntry::UDS_LINK_DEST" at all. That leads me to think that this
>> > UDS_LINK_DEST might not be needed. Can i safely remove the
>> > "UDSEntry::UDS_LINK_DEST" from the details == 0 code path?
>> > Patch is here: http://paste.kde.org/pad68d0af/
>>
>> That's not a fix, that's removing a feature instead of fixing it :-)
>>
>> UDS_LINK_DEST should only be set for symlinks.
>> Are you saying that ep->d_type & DT_LNK is true for normal files too?
>> Ah I see:
>> This should say ep->d_type == DT_LNK, it's not a bitfield.
>> (DT_LNK is 10, DT_REG is 8)
>> Same for the other tests for d_type, they should all use == then.
>> Can you test if that fixes what you're seeing, and commit (to 4.11) if so?
>> Thanks.
>>
>> --
>> David Faure, faure@kde.org, http://www.davidfaure.fr
>> Working on KDE, in particular KDE Frameworks 5
>>
>>
> I'm doing a bit of thread hijacking now (funny since i made it in the
> first place ;p)
> The patch: http://paste.kde.org/p2ece1fd8/
> Besides the line you said i also changed the line above. Hence asking for
> a "OK" to commit.
> Compile tested on 4.11 and works. The KIO Testcases run just fine as well
> though i doubt they test for this case.
>
> Then a few questions for frameworks. How do i merge this change back in
> frameworks?
>
> Note: i'm right now making a unittest for this specific case in
> frameworks, not for 4.11. Just a general "udsentrytest" which should later
> be extended to cover more of UDSEntry.
>
[Attachment #3 (text/html)]
<div dir="ltr">compile and run tested on frameworks. Also OK. I actually had one \
symlinked file (kdesrc-build) which still shows up as that dummy symlink which is as \
expected if i follow the code.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Sat, Sep 21, 2013 at 3:45 PM, Mark <span \
dir="ltr"><<a href="mailto:markg85@gmail.com" \
target="_blank">markg85@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div dir="ltr"><div><div class="h5">On Sat, Sep 21, 2013 at 10:59 AM, David Faure \
<span dir="ltr"><<a href="mailto:faure@kde.org" \
target="_blank">faure@kde.org</a>></span> wrote:<br><div class="gmail_extra"><div \
class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>On Thursday 19 September 2013 23:13:04 Mark wrote:<br>
> If i set details to 0 i'm welcomed by a "UDSEntry::UDS_LINK_DEST" \
that<br> > always seems to be: "Dummy Link Target".<br>
> When i don't set details (which means details is 2) then i don't have \
a<br> > "UDSEntry::UDS_LINK_DEST" at all. That leads me to think that \
this<br> > UDS_LINK_DEST might not be needed. Can i safely remove the<br>
> "UDSEntry::UDS_LINK_DEST" from the details == 0 code path?<br>
> Patch is here: <a href="http://paste.kde.org/pad68d0af/" \
target="_blank">http://paste.kde.org/pad68d0af/</a><br> <br>
</div>That's not a fix, that's removing a feature instead of fixing it \
:-)<br> <br>
UDS_LINK_DEST should only be set for symlinks.<br>
Are you saying that ep->d_type & DT_LNK is true for normal files too?<br>
Ah I see:<br>
This should say ep->d_type == DT_LNK, it's not a bitfield.<br>
(DT_LNK is 10, DT_REG is 8)<br>
Same for the other tests for d_type, they should all use == then.<br>
Can you test if that fixes what you're seeing, and commit (to 4.11) if so?<br>
Thanks.<br>
<div><div><br>
--<br>
David Faure, <a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>, <a \
href="http://www.davidfaure.fr" target="_blank">http://www.davidfaure.fr</a><br> \
Working on KDE, in particular KDE Frameworks 5<br> <br>
</div></div></blockquote></div><br></div></div></div><div class="gmail_extra">I'm \
doing a bit of thread hijacking now (funny since i made it in the first place \
;p)</div><div class="gmail_extra">The patch: <a \
href="http://paste.kde.org/p2ece1fd8/" \
target="_blank">http://paste.kde.org/p2ece1fd8/</a></div>
<div class="gmail_extra">Besides the line you said i also changed the line above. \
Hence asking for a "OK" to commit.</div><div class="gmail_extra">Compile \
tested on 4.11 and works. The KIO Testcases run just fine as well though i doubt they \
test for this case.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Then a few questions for \
frameworks. How do i merge this change back in frameworks?</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">Note: i'm right now making \
a unittest for this specific case in frameworks, not for 4.11. Just a general \
"udsentrytest" which should later be extended to cover more of \
UDSEntry.</div>
</div>
</blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic