From kfm-devel Sat Sep 21 08:59:28 2013 From: David Faure Date: Sat, 21 Sep 2013 08:59:28 +0000 To: kfm-devel Subject: Re: UDSEntry compression ideas Message-Id: <1699029.Z0PBGomy5s () asterix> X-MARC-Message: https://marc.info/?l=kfm-devel&m=137975363307822 On Thursday 19 September 2013 23:13:04 Mark wrote: > If i set details to 0 i'm welcomed by a "UDSEntry::UDS_LINK_DEST" that > always seems to be: "Dummy Link Target". > When i don't set details (which means details is 2) then i don't have a > "UDSEntry::UDS_LINK_DEST" at all. That leads me to think that this > UDS_LINK_DEST might not be needed. Can i safely remove the > "UDSEntry::UDS_LINK_DEST" from the details == 0 code path? > Patch is here: http://paste.kde.org/pad68d0af/ That's not a fix, that's removing a feature instead of fixing it :-) UDS_LINK_DEST should only be set for symlinks. Are you saying that ep->d_type & DT_LNK is true for normal files too? Ah I see: This should say ep->d_type == DT_LNK, it's not a bitfield. (DT_LNK is 10, DT_REG is 8) Same for the other tests for d_type, they should all use == then. Can you test if that fixes what you're seeing, and commit (to 4.11) if so? Thanks. -- David Faure, faure@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5