[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Review Request 112589: Use the Nepomuk Query Builder widget to add syntax-highlighting in Dolphin se
From: "Denis Steckelmacher" <steckdenis () yahoo ! fr>
Date: 2013-09-08 11:58:29
Message-ID: 20130908115829.1989.19632 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112589/
-----------------------------------------------------------
Review request for Dolphin.
Description
-------
When Dolphin is compiled with Nepomuk support, this patch replaces the plain line \
edit in which the user enters a search query with the new auto-completed QueryBuilder \
widget.
The user interface of the widget is shown in \
http://steckdenis.be/static/images/dolphin-query-builder.png .
The QueryBuilder widget can be found in the "steckdenis-gsoc2013" branch of \
nepomuk-widgets. You will also need the "steckdenis-gsoc2013" branch of nepomuk-core. \
This patch is not yet ready for merging as we have to wait that my other branches get \
merged in nepomuk-core and nepomuk-widgets. Some small changes in the API of the \
QueryBuilder are still possible.
Diffs
-----
dolphin/src/search/dolphinsearchbox.h f3cc535
dolphin/src/search/dolphinsearchbox.cpp ef9c2bf
Diff: http://git.reviewboard.kde.org/r/112589/diff/
Testing
-------
Compiling with the CMake variable WITH_NepomukWidgets set to ON is possible and the \
resulting Dolphin works as expected (the query builder widget is displayed and \
queries can be entered in it). When this variable is set to OFF, Dolphin still builds \
and runs correctly, except that there is no auto-completion available.
The only problem is that even without the patch (and Nepomuk enabled system-wide and \
at compile time), Dolphin does not seem to use Nepomuk queries. Every search \
operation is slow and there is a huge amount of disk activity. Nepomuk queries like \
"modified last week" work perfectly well in KRunner. This problem (likely due to a \
misconfiguration on my desktop as it is present in Dolphin master and Dolphin 4.11, \
with Nepomuk-Core master or 4.11) prevents me from testing that queries entered in \
the query builder actually work. Can somebody with a working dolphin test that ?
Thanks,
Denis Steckelmacher
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112589/">http://git.reviewboard.kde.org/r/112589/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Denis Steckelmacher.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When Dolphin is compiled with Nepomuk support, this patch replaces the \
plain line edit in which the user enters a search query with the new auto-completed \
QueryBuilder widget.
The user interface of the widget is shown in \
http://steckdenis.be/static/images/dolphin-query-builder.png .
The QueryBuilder widget can be found in the "steckdenis-gsoc2013" branch of \
nepomuk-widgets. You will also need the "steckdenis-gsoc2013" branch of \
nepomuk-core. This patch is not yet ready for merging as we have to wait that my \
other branches get merged in nepomuk-core and nepomuk-widgets. Some small changes in \
the API of the QueryBuilder are still possible.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiling with the CMake variable WITH_NepomukWidgets set to ON is \
possible and the resulting Dolphin works as expected (the query builder widget is \
displayed and queries can be entered in it). When this variable is set to OFF, \
Dolphin still builds and runs correctly, except that there is no auto-completion \
available.
The only problem is that even without the patch (and Nepomuk enabled system-wide and \
at compile time), Dolphin does not seem to use Nepomuk queries. Every search \
operation is slow and there is a huge amount of disk activity. Nepomuk queries like \
"modified last week" work perfectly well in KRunner. This problem (likely \
due to a misconfiguration on my desktop as it is present in Dolphin master and \
Dolphin 4.11, with Nepomuk-Core master or 4.11) prevents me from testing that queries \
entered in the query builder actually work. Can somebody with a working dolphin test \
that ?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/search/dolphinsearchbox.h <span style="color: \
grey">(f3cc535)</span></li>
<li>dolphin/src/search/dolphinsearchbox.cpp <span style="color: \
grey">(ef9c2bf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112589/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic