[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 111807: Add some unit test for groups in KFileItemModel
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2013-08-02 14:21:47
Message-ID: 20130802142147.22642.53291 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111807/#review36991
-----------------------------------------------------------
Ship it!
Ship It!
- Emmanuel Pescosta
On July 30, 2013, 10:01 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111807/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 10:01 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> This new unit test tests grouping in KFileItemModel, in particular the aspects that \
> I would have broken with https://git.reviewboard.kde.org/r/111721/, as Emmanuel \
> found out fortunately :-)
> Moreover, the commit reduces the timeout for the "resort all items" timer. This \
> greatly speeds up the unit tests.
>
> Diffs
> -----
>
> dolphin/src/tests/kfileitemmodeltest.cpp 0ad7a37
>
> Diff: http://git.reviewboard.kde.org/r/111807/diff/
>
>
> Testing
> -------
>
> New unit test passes, and breaks when I apply the current version of \
> https://git.reviewboard.kde.org/r/111721/
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111807/">http://git.reviewboard.kde.org/r/111807/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Emmanuel</p>
<br />
<p>On July 30th, 2013, 10:01 p.m. UTC, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated July 30, 2013, 10:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This new unit test tests grouping in KFileItemModel, in particular the \
aspects that I would have broken with https://git.reviewboard.kde.org/r/111721/, as \
Emmanuel found out fortunately :-)
Moreover, the commit reduces the timeout for the "resort all items" timer. \
This greatly speeds up the unit tests.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New unit test passes, and breaks when I apply the current version of \
https://git.reviewboard.kde.org/r/111721/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/tests/kfileitemmodeltest.cpp <span style="color: \
grey">(0ad7a37)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111807/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic