[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 111836: dolphin: Escape text in statusbar tooltip
From: "Fabio D'Urso" <fabiodurso () hotmail ! it>
Date: 2013-08-01 15:59:41
Message-ID: 20130801155941.18917.59722 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 1, 2013, 2:42 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! Could you describe how the problem can be reproduced? When \
> > I move the mouse cursor to the status bar, the file name disappears from the \
> > status bar, so I don't get the tool tip at all.
Yes, sorry: create a file named "Tes<font color=red>t test test test test test", \
select it and hover on the status bar.
- Fabio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111836/#review36918
-----------------------------------------------------------
On Aug. 1, 2013, 1:58 p.m., Fabio D'Urso wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111836/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 1:58 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> I've found that the statusbar's tooltip renders HTML-looking filenames as HTML too. \
> This patch escapes the tooltip text.
>
> Diffs
> -----
>
> dolphin/src/statusbar/dolphinstatusbar.cpp 1489191
>
> Diff: http://git.reviewboard.kde.org/r/111836/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fabio D'Urso
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111836/">http://git.reviewboard.kde.org/r/111836/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 1st, 2013, 2:42 p.m. UTC, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for the patch! Could you describe how the problem can be \
reproduced? When I move the mouse cursor to the status bar, the file name disappears \
from the status bar, so I don't get the tool tip at all.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, sorry: create a \
file named "Tes<font color=red>t test test test test test", select it \
and hover on the status bar.</pre> <br />
<p>- Fabio</p>
<br />
<p>On August 1st, 2013, 1:58 p.m. UTC, Fabio D'Urso wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Fabio D'Urso.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2013, 1:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've found that the statusbar's tooltip renders HTML-looking \
filenames as HTML too. This patch escapes the tooltip text. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/statusbar/dolphinstatusbar.cpp <span style="color: \
grey">(1489191)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111836/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic