[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Should fast mime detection use a stat call?
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2013-06-17 18:44:31
Message-ID: CAFoZWWiz4-B+E-6ocx094g=yJoE0WDkHNLi=x7gwr64jUnQ2CA () mail ! gmail ! com
[Download RAW message or body]

Hi,

2013/6/17 Mark:
> On Mon, Jun 17, 2013 at 4:13 PM, David Faure wrote:
>> Le lundi 17 juin 2013 09:54:02 Mark a =E9crit :
[...]
>>> However, that
>>> stat data isn't send to KMimeType so another way would be to require a
>>> "KFileItem" which knows more about a file instead of a KUrl (QUrl in
>>> kde frameworks). But then again, that requires app side changes...
>>
>> No, just ensure that the calls to KMimeType that you're looking at, get =
the
>> mode_t from the KFileItem. I.e. don't change KMimeType itself (for that
>> particular issue), change the callers to provide more information, and g=
et
>> more speed out of it. This way, other callers won't break.
>
> Will do so.
>
> @Frank, do you happen to know what dolphin does here? Is it passing
> this mode property?

Dolphin does not call KMimeType funcions directly. It just uses it
indirectly via KFileItem. If KMimeType does make superfluous stat
calls when being called indirectly from Dolphin (I don't know if that
is the case), then I think that this can only be fixed inside
KFileItem.

Regards,
Frank
[prev in list] [next in list] [prev in thread] [next in thread]