[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 110970: Use Tab to switch between views
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2013-06-13 15:50:00
Message-ID: 20130613155000.27579.49757 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110970/#review34306
-----------------------------------------------------------
Thanks Aurelién for the patch! It's true that switching between views with the \
keyboard is painful, to say the least. I also agree that Tab looks like an obvious \
choice, but I'm not sure if this could lead to problems (you already mentioned some).
I'm wondering if a cleaner approach would be to add create a new KAction in \
DolphinMainWindow that switches between views? We could use a default shortcut that \
is unlikely to cause conflicts, like Ctrl+Shift+Tab (or no default shortcut at all). \
And then people could just assign Tab to that action in the shortcut editor if they \
want. What do you think?
- Frank Reininghaus
On June 12, 2013, 10:29 a.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110970/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 10:29 a.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> Use the Tab key to switch between views. It may be a bit worrying the way the Tab \
> key is spied on, but it means it is still possible to use Tab and Shift-Tab to \
> navigate other areas of the application. For example, pressing Shift-Tab while a \
> view is focused places the focus on the last element of the url navigator. From \
> there, one can use Shift-Tab and Tab to focus different elements of the navigator. \
> Pressing Tab while on the last element of the navigator puts the focus back on the \
> view.
>
> This addresses bug 171743.
> http://bugs.kde.org/show_bug.cgi?id=171743
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp 73001bf54e957c967b8203fc06af7556005f8d12
> dolphin/src/views/dolphinview.h d77a3a19806cbe8b1ecc1349b82009ef4c3db826
> dolphin/src/views/dolphinview.cpp 16b92801be73f6a299dff96c0a6c7506f03f6b42
>
> Diff: http://git.reviewboard.kde.org/r/110970/diff/
>
>
> Testing
> -------
>
> Tested in single and splitted view. I noticed a few glitches, which you may or may \
> not consider blockers:
> - When the filter widget is visible, it cannot be focused by pressing tab anymore. \
> It is still nevertheless possible to focus it with Ctrl+I or its access key.
> - Same thing with the find widget. Still focusable with Ctrl+F.
>
> - When one creates a new tab, the current view is not focused, so pressing "Tab" \
> does not move the focus to the other view. I have the feeling this is independent \
> from the patch and could be fixed y setting the focus to the view when a new tab is \
> created.
>
> Thanks,
>
> Aurélien Gâteau
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110970/">http://git.reviewboard.kde.org/r/110970/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Aurelién for the \
patch! It's true that switching between views with the keyboard is painful, to \
say the least. I also agree that Tab looks like an obvious choice, but I'm not \
sure if this could lead to problems (you already mentioned some).
I'm wondering if a cleaner approach would be to add create a new KAction in \
DolphinMainWindow that switches between views? We could use a default shortcut that \
is unlikely to cause conflicts, like Ctrl+Shift+Tab (or no default shortcut at all). \
And then people could just assign Tab to that action in the shortcut editor if they \
want. What do you think?</pre> <br />
<p>- Frank</p>
<br />
<p>On June 12th, 2013, 10:29 a.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated June 12, 2013, 10:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the Tab key to switch between views. It may be a bit worrying the \
way the Tab key is spied on, but it means it is still possible to use Tab and \
Shift-Tab to navigate other areas of the application. For example, pressing Shift-Tab \
while a view is focused places the focus on the last element of the url navigator. \
From there, one can use Shift-Tab and Tab to focus different elements of the \
navigator. Pressing Tab while on the last element of the navigator puts the focus \
back on the view.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in single and splitted view. I noticed a few glitches, which you \
may or may not consider blockers:
- When the filter widget is visible, it cannot be focused by pressing tab anymore. It \
is still nevertheless possible to focus it with Ctrl+I or its access key.
- Same thing with the find widget. Still focusable with Ctrl+F.
- When one creates a new tab, the current view is not focused, so pressing \
"Tab" does not move the focus to the other view. I have the feeling this is \
independent from the patch and could be fixed y setting the focus to the view when a \
new tab is created.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=171743">171743</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(73001bf54e957c967b8203fc06af7556005f8d12)</span></li>
<li>dolphin/src/views/dolphinview.h <span style="color: \
grey">(d77a3a19806cbe8b1ecc1349b82009ef4c3db826)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(16b92801be73f6a299dff96c0a6c7506f03f6b42)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110970/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic