[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Review Request 110966: Do not use a fixed size for the widgets in the status bar
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2013-06-12 7:20:47
Message-ID: 20130612072047.28128.79410 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110966/
-----------------------------------------------------------
Review request for Dolphin.
Description
-------
The zoom slider, free space bar, and progress bar in the status bar have a fixed size \
since
http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=213450d39704fc0154da5f0e45e4198af8239842
This causes problems when the user tries to make the window more narrow, see bug \
319373.
On the one hand, one could argue that the widgets need a certain size to be useful, \
but on the other hand, I think that we should not annoy the user if he/she really \
wants to have a narrow window.
The problem that translated space information might need more horizontal space and is \
thus not shown fully is still open (bug 318395). I'm not sure if this one can be \
fixed cleanly in Dolphin alone, or if some adjustments in KCapacityBar are required. \
It seems that the mimimumSizeHint of this class isn't even sufficient to show the \
text.
This addresses bug 319373.
http://bugs.kde.org/show_bug.cgi?id=319373
Diffs
-----
dolphin/src/statusbar/dolphinstatusbar.h d7e37f5
dolphin/src/statusbar/dolphinstatusbar.cpp 068b632
Diff: http://git.reviewboard.kde.org/r/110966/diff/
Testing
-------
Works for me.
Thanks,
Frank Reininghaus
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110966/">http://git.reviewboard.kde.org/r/110966/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The zoom slider, free space bar, and progress bar in the status bar have \
a fixed size since
http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=213450d39704fc0154da5f0e45e4198af8239842
This causes problems when the user tries to make the window more narrow, see bug \
319373.
On the one hand, one could argue that the widgets need a certain size to be useful, \
but on the other hand, I think that we should not annoy the user if he/she really \
wants to have a narrow window.
The problem that translated space information might need more horizontal space and is \
thus not shown fully is still open (bug 318395). I'm not sure if this one can be \
fixed cleanly in Dolphin alone, or if some adjustments in KCapacityBar are required. \
It seems that the mimimumSizeHint of this class isn't even sufficient to show the \
text.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319373">319373</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/statusbar/dolphinstatusbar.h <span style="color: \
grey">(d7e37f5)</span></li>
<li>dolphin/src/statusbar/dolphinstatusbar.cpp <span style="color: \
grey">(068b632)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110966/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic