[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 110908: When changing the URL while renaming inline,
From: "Commit Hook" <null () kde ! org>
Date: 2013-06-10 19:33:41
Message-ID: 20130610193341.20516.20902 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110908/#review34083
-----------------------------------------------------------
This review has been submitted with commit 5948dc0f3316ac5c60b6825e7cf997d7634642f6 \
by Frank Reininghaus to branch KDE/4.10.
- Commit Hook
On June 10, 2013, 7:22 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110908/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 7:22 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> If the "role editor" loses focus, it considers the current renaming operation \
> finished, and tells DolphinView to rename the file. This is a problem when changing \
> the directory, because the URL change happens *before* DolphinView receives the \
> signal, which results in a file in the new directory being renamed unexpectedly.
> Currently, the DolphinView is connected to the "slotRoleEditingFinished" signal \
> permanently. I propose to change this and only establish the connection when the \
> "rename inline" editor is opened, and disconnect it when renaming is finished or \
> canceled or the URL changes.
>
> This addresses bug 319912.
> http://bugs.kde.org/show_bug.cgi?id=319912
>
>
> Diffs
> -----
>
> dolphin/src/views/dolphinview.h a2fe9f6
> dolphin/src/views/dolphinview.cpp 502ffd4
>
> Diff: http://git.reviewboard.kde.org/r/110908/diff/
>
>
> Testing
> -------
>
> Works for me.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110908/">http://git.reviewboard.kde.org/r/110908/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5948dc0f3316ac5c60b6825e7cf997d7634642f6 by Frank Reininghaus \
to branch KDE/4.10.</pre> <br />
<p>- Commit</p>
<br />
<p>On June 10th, 2013, 7:22 p.m. UTC, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated June 10, 2013, 7:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If the "role editor" loses focus, it considers the current \
renaming operation finished, and tells DolphinView to rename the file. This is a \
problem when changing the directory, because the URL change happens *before* \
DolphinView receives the signal, which results in a file in the new directory being \
renamed unexpectedly.
Currently, the DolphinView is connected to the "slotRoleEditingFinished" \
signal permanently. I propose to change this and only establish the connection when \
the "rename inline" editor is opened, and disconnect it when renaming is \
finished or canceled or the URL changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319912">319912</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(a2fe9f6)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(502ffd4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110908/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic