This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107392/ |
Thanks for the new patch and sorry for the late reply! Real life kept me quite busy around Christmas, so I had no time to have a closer look at it and test it. I think it might indeed be better to do it without the configurable keyboard shortcut. Not only because it's easier from an implementation and maintenance point of view, but also because basically all actions shown in the "Configure Shortcuts" dialog can be invoked in the "default state" of the DolphinView. This would not be the case for the "Lock filter text" action (or at least it would not have any visible effect if it was toggled). So the remaining issue that needs to be resolved before we can include this feature is the icon. If you don't want to use "system-lock-screen" or anything else that exists already, you might want to get in touch with the Oxygen people (i.e., by including Nuno Pinheiro in the 'People' section of this review) and ask them about their opinion.
- Frank
On December 20th, 2012, 6:53 p.m., Stuart Citrin wrote:
Review request for Dolphin and KDE Usability.
By Stuart Citrin.
Updated Dec. 20, 2012, 6:53 p.m. Description
Testing
Diffs
Screenshots |