From kfm-devel Thu Dec 27 19:48:53 2012 From: "Frank Reininghaus" Date: Thu, 27 Dec 2012 19:48:53 +0000 To: kfm-devel Subject: Re: Review Request: Proposal to add a 'lock toggle button' to filter bar to Message-Id: <20121227194853.23933.55021 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=135663775929818 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8496760377126210379==" --===============8496760377126210379== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107392/#review24069 ----------------------------------------------------------- Thanks for the new patch and sorry for the late reply! Real life kept me qu= ite busy around Christmas, so I had no time to have a closer look at it and= test it. I think it might indeed be better to do it without the configurable keyboar= d shortcut. Not only because it's easier from an implementation and mainten= ance point of view, but also because basically all actions shown in the "Co= nfigure Shortcuts" dialog can be invoked in the "default state" of the Dolp= hinView. This would not be the case for the "Lock filter text" action (or a= t least it would not have any visible effect if it was toggled). So the remaining issue that needs to be resolved before we can include this= feature is the icon. If you don't want to use "system-lock-screen" or anyt= hing else that exists already, you might want to get in touch with the Oxyg= en people (i.e., by including Nuno Pinheiro in the 'People' section of this= review) and ask them about their opinion. - Frank Reininghaus On Dec. 20, 2012, 6:53 p.m., Stuart Citrin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107392/ > ----------------------------------------------------------- > = > (Updated Dec. 20, 2012, 6:53 p.m.) > = > = > Review request for Dolphin and KDE Usability. > = > = > Description > ------- > = > I wrote a quick add-on for the Dolphin filter bar. It is a button which= prevents the filter text from clearing when navigating to a different fold= er. = > = > Why this might be needed: > = > This is an attempt to resolve the following usability conflict: = > = > If one navigates to a different folder, the filter is automatically clear= ed since one does not want a situation where someone forgets a filter is ap= plied and then doesn't understand why all the files within a folder are not= appearing.(current behavior) = > versus: = > A user might want to keep a filter while navigating an arbitrary set of f= olders, but is unable to, since the filter is automatically cleared upon na= vigation = > = > The implementation to try to resolve this conflict is as follows: = > = > 1. A lock filter toggle button is added to the right side of the filter b= ar. = > 2. If the lock filter button is clicked(on), then if the user navigates a= way from the current folder, the filter is not cleared. If the lock filter = button is released(off), then the text is cleared on navigation...which is = the current behavior. = > 3. A configurable shortcut is added to toggle the lock filter button, wit= h the default being Ctrl-Shift-I (since the default shortcut for hiding and= showing the filter bar is Ctrl-I.) = > 4. If the user toggles the lock filter button to released (off), then the= text in the filter also clears. The assumption here is that if the user no= longer wants the text to be locked, he probably also wants to clear the te= xt. > 5. When the filter bar is hidden, then the lock filter button is release= d. The next time the filter bar is shown, the lock filter button will be in= the released(off) position and the filter text will have been cleared. = > 6. At application startup, the lock filter button is always off, and the = filter bar text cleared. = > = > This also fixes a current bug in dolphin where one is unable to toggle th= e visibility of the filter bar using the tool bar filter button, or by usin= g the assigned hot key. > = > Note... I think it is 'patch -p2' from the "dolphin" directory (above src= directory ) to apply the patch > = > = > Diffs > ----- > = > dolphin/src/dolphinmainwindow.h 7da5801 = > dolphin/src/dolphinmainwindow.cpp 11e03d0 = > dolphin/src/dolphinviewcontainer.h e2d1b18 = > dolphin/src/dolphinviewcontainer.cpp c27550a = > dolphin/src/filterbar/filterbar.h 9546c63 = > dolphin/src/filterbar/filterbar.cpp f3076f0 = > = > Diff: http://git.reviewboard.kde.org/r/107392/diff/ > = > = > Testing > ------- > = > Went through all paths in dolphin. Tested: 1. Navigate to different fold= er. Text should clear only when text not locked > 2.Ctl-I shortcut to toggle visiblility of filterbar > 3.Text clears when filterbar hidden and then shown > 4. Lock button locks and unlocks text > 5. Shift-Ctl-I shortcut to toggle lock status of text. Lock button updat= es appropriately > 6. Status (with non-perisistence from previous instance) of lock button w= hen starting application..i.e. lock status is off on startup > 7. Change keyboard shortcuts...works appropriately > 8. F3 and split view..tabs..etc.. should still work appropriately > 9. Monkey tested...cannot get it to crash > etc.... > = > = > Screenshots > ----------- > = > Filter bar with new text locking button > http://git.reviewboard.kde.org/r/107392/s/877/ > = > = > Thanks, > = > Stuart Citrin > = > --===============8496760377126210379== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107392/ 

Thanks for=
 the new patch and sorry for the late reply! Real life kept me quite busy a=
round Christmas, so I had no time to have a closer look at it and test it.

I think it might indeed be better to do it without the configurable keyboar=
d shortcut. Not only because it's easier from an implementation and mai=
ntenance point of view, but also because basically all actions shown in the=
 "Configure Shortcuts" dialog can be invoked in the "default=
 state" of the DolphinView. This would not be the case for the "L=
ock filter text" action (or at least it would not have any visible eff=
ect if it was toggled).

So the remaining issue that needs to be resolved before we can include this=
 feature is the icon. If you don't want to use "system-lock-screen=
" or anything else that exists already, you might want to get in touch=
 with the Oxygen people (i.e., by including Nuno Pinheiro in the 'Peopl=
e' section of this review) and ask them about their opinion.

- Frank


On December 20th, 2012, 6:53 p.m., Stuart Citrin wrote:

Review request for Dolphin and KDE Usability.
By Stuart Citrin.

Updated Dec. 20, 2012, 6:53 p.m.

Descripti= on 

I wrote a quick add-on for the Dolphin filter bar.   It is a=
 button which prevents the filter text from clearing when navigating to a d=
ifferent folder. =


Why this might be needed:

This is an attempt to resolve the following usability conflict: =


If one navigates to a different folder, the filter is automatically cleared=
 since one does not want a situation where someone forgets a filter is appl=
ied and then doesn't understand why all the files within a folder are n=
ot appearing.(current behavior) =

versus: =

A user might want to keep a filter while navigating an arbitrary set of fol=
ders, but is unable to, since the filter is automatically cleared upon navi=
gation =


The implementation to try to resolve this conflict is as follows: =


1. A lock filter toggle button is added to the right side of the filter bar=
. =

2. If the lock filter button is clicked(on), then if the user navigates awa=
y from the current folder, the filter is not cleared. If the lock filter bu=
tton is released(off), then the text is cleared on navigation...which is th=
e current behavior. =

3. A configurable shortcut is added to toggle the lock filter button, with =
the default being Ctrl-Shift-I (since the default shortcut for hiding and s=
howing the filter bar is Ctrl-I.) =

4. If the user toggles the lock filter button to released (off), then the t=
ext in the filter also clears. The assumption here is that if the user no l=
onger wants the text to be locked, he probably also wants to clear the text.
 5. When the filter bar is hidden, then the lock filter button is released.=
 The next time the filter bar is shown, the lock filter button will be in t=
he released(off) position and the filter text will have been cleared. =

6. At application startup, the lock filter button is always off, and the fi=
lter bar text cleared. =


This also fixes a current bug in dolphin where one is unable to toggle the =
visibility of the filter bar using the tool bar filter button, or by using =
the assigned hot key.

Note... I think it is 'patch -p2' from the "dolphin" dire=
ctory (above src directory ) to apply the patch

Testing <= /h1> 
Went through all paths in dolphin.  Tested: 1. Navigate to d=
ifferent folder. Text should clear only when text not locked
2.Ctl-I shortcut to toggle visiblility of filterbar
3.Text clears when filterbar hidden and then shown
4. Lock button locks and unlocks text
5. Shift-Ctl-I shortcut to toggle lock status of text.  Lock button updates=
 appropriately
6. Status (with non-perisistence from previous instance) of lock button whe=
n starting application..i.e. lock status is off on startup
7. Change keyboard shortcuts...works appropriately
8. F3 and split view..tabs..etc.. should still work appropriately
9. Monkey tested...cannot get it to crash
etc....

Diffs=

  • dolphin/src/dolphinmainwindow.h (7da5801)<= /span>
  • dolphin/src/dolphinmainwindow.cpp (11e03d0= )
  • dolphin/src/dolphinviewcontainer.h (e2d1b1= 8)
  • dolphin/src/dolphinviewcontainer.cpp (c275= 50a)
  • dolphin/src/filterbar/filterbar.h (9546c63= )
  • dolphin/src/filterbar/filterbar.cpp (f3076= f0)

View Diff

Screensho= ts

3D"Filter
--===============8496760377126210379==--