[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Proposal to add a 'lock toggle button' to filter bar to
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2012-11-22 15:26:44
Message-ID: 20121122152644.14823.63479 () vidsolbach ! de
[Download RAW message or body]
> On Nov. 22, 2012, 12:28 p.m., Frank Reininghaus wrote:
> > Thanks for the patch!
> >
> > I'm not at home right now and therefore can't test it at the moment, but here are \
> > some things that come to my mind:
> > 1. Even though the idea looks nice, I'm wondering if the 'lock' button has the \
> > potential to confuse users. I mean, I see that noone except you has ever \
> > requested this feature, but everyone will see the button if we implement it, and \
> > wonder what it's for. At first sight, nothing happens if you click the button, so \
> > I see the risk that people get confused.
> > 2. "This also fixes a current bug in dolphin where one is unable to toggle the \
> > visibility of the filter bar using the tool bar filter button, or by using the \
> > assigned hot key.": I just looked through the bug list and found out that this is \
> > the intended behaviour: https://bugs.kde.org/show_bug.cgi?id=215138
> > @Emmanuel: You did a good job looking through the code!
> >
> > "For future patches: You should add Frank as a reviewer for all Dolphin related \
> > patch reviews.": No, this is not necessary. It doesn't make any difference for me \
> > - Dolphin-related review requests end up in my inbox anyway ;-)
> 1. Even though the idea looks nice, I'm wondering if the 'lock' button has the \
> potential to confuse users.
Yep, I think it's a very good idea (I missed such a feature ... always copied the \
filter-string to use it in other folders ;)
But:
What if we add a toggle button [on/off] (show files with/without filter applied) and \
don't clear the filter-string on Url change? - This approach has also the advantage, \
that you can easily disable the filter without removing the filter-string and without \
closing the filter-bar (Also a small workflow issue in my mind), afterwards you can \
simply reactivate the filter (with the old filter-string ;)
@Stuart, @Frank: What do you think about my idea?
> @Emmanuel: You did a good job looking through the code!
Thanks, learned a lot about coding (and code styling) in the last few months :)
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107392/#review22377
-----------------------------------------------------------
On Nov. 20, 2012, 5:16 a.m., Stuart Citrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107392/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2012, 5:16 a.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> I wrote a quick add-on for the Dolphin filter bar. It is a button which prevents \
> the filter text from clearing when navigating to a different folder.
> Why this might be needed:
>
> This is an attempt to resolve the following usability conflict:
>
> If one navigates to a different folder, the filter is automatically cleared since \
> one does not want a situation where someone forgets a filter is applied and then \
> doesn't understand why all the files within a folder are not appearing.(current \
> behavior)
> versus:
> A user might want to keep a filter while navigating an arbitrary set of folders, \
> but is unable to, since the filter is automatically cleared upon navigation
> The implementation to try to resolve this conflict is as follows:
>
> 1. A lock filter toggle button is added to the right side of the filter bar.
> 2. If the lock filter button is clicked(on), then if the user navigates away from \
> the current folder, the filter is not cleared. If the lock filter button is \
> released(off), then the text is cleared on navigation...which is the current \
> behavior. 3. A configurable shortcut is added to toggle the lock filter button, \
> with the default being Ctrl-Shift-I (since the default shortcut for hiding and \
> showing the filter bar is Ctrl-I.) 4. If the user toggles the lock filter button \
> to released (off), then the text in the filter also clears. The assumption here is \
> that if the user no longer wants the text to be locked, he probably also wants to \
> clear the text. 5. When the filter bar is hidden, then the lock filter button is \
> released. The next time the filter bar is shown, the lock filter button will be in \
> the released(off) position and the filter text will have been cleared. 6. At \
> application startup, the lock filter button is always off, and the filter bar text \
> cleared.
> This also fixes a current bug in dolphin where one is unable to toggle the \
> visibility of the filter bar using the tool bar filter button, or by using the \
> assigned hot key.
> Note... I think it is 'patch -p2' from the "dolphin" directory (above src directory \
> ) to apply the patch
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 7da5801
> dolphin/src/dolphinmainwindow.cpp 11e03d0
> dolphin/src/dolphinviewcontainer.h 0300273
> dolphin/src/dolphinviewcontainer.cpp 6e99437
> dolphin/src/filterbar/filterbar.h 9546c63
> dolphin/src/filterbar/filterbar.cpp f3076f0
>
> Diff: http://git.reviewboard.kde.org/r/107392/diff/
>
>
> Testing
> -------
>
> Went through all paths in dolphin. Tested: 1. Navigate to different folder. Text \
> should clear only when text not locked 2.Ctl-I shortcut to toggle visiblility of \
> filterbar 3.Text clears when filterbar hidden and then shown
> 4. Lock button locks and unlocks text
> 5. Shift-Ctl-I shortcut to toggle lock status of text. Lock button updates \
> appropriately 6. Status (with non-perisistence from previous instance) of lock \
> button when starting application..i.e. lock status is off on startup 7. Change \
> keyboard shortcuts...works appropriately 8. F3 and split view..tabs..etc.. should \
> still work appropriately 9. Monkey tested...cannot get it to crash
> etc....
>
>
> Thanks,
>
> Stuart Citrin
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107392/">http://git.reviewboard.kde.org/r/107392/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 22nd, 2012, 12:28 p.m., <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for the patch!
I'm not at home right now and therefore can't test it at the moment, but here \
are some things that come to my mind:
1. Even though the idea looks nice, I'm wondering if the 'lock' button \
has the potential to confuse users. I mean, I see that noone except you has ever \
requested this feature, but everyone will see the button if we implement it, and \
wonder what it's for. At first sight, nothing happens if you click the button, so \
I see the risk that people get confused.
2. "This also fixes a current bug in dolphin where one is unable to toggle the \
visibility of the filter bar using the tool bar filter button, or by using the \
assigned hot key.": I just looked through the bug list and found out that this \
is the intended behaviour: https://bugs.kde.org/show_bug.cgi?id=215138
@Emmanuel: You did a good job looking through the code!
"For future patches: You should add Frank as a reviewer for all Dolphin related \
patch reviews.": No, this is not necessary. It doesn't make any difference \
for me - Dolphin-related review requests end up in my inbox anyway ;-) </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> 1. Even though the \
idea looks nice, I'm wondering if the 'lock' button has the potential to \
confuse users. Yep, I think it's a very good idea (I missed such a feature ... \
always copied the filter-string to use it in other folders ;)
But:
What if we add a toggle button [on/off] (show files with/without filter applied) and \
don't clear the filter-string on Url change? - This approach has also the \
advantage, that you can easily disable the filter without removing the filter-string \
and without closing the filter-bar (Also a small workflow issue in my mind), \
afterwards you can simply reactivate the filter (with the old filter-string ;)
@Stuart, @Frank: What do you think about my idea?
> @Emmanuel: You did a good job looking through the code!
Thanks, learned a lot about coding (and code styling) in the last few months :)</pre>
<br />
<p>- Emmanuel</p>
<br />
<p>On November 20th, 2012, 5:16 a.m., Stuart Citrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Stuart Citrin.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2012, 5:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I wrote a quick add-on for the Dolphin filter bar. It is a button \
which prevents the filter text from clearing when navigating to a different folder.
Why this might be needed:
This is an attempt to resolve the following usability conflict:
If one navigates to a different folder, the filter is automatically cleared since one \
does not want a situation where someone forgets a filter is applied and then \
doesn't understand why all the files within a folder are not appearing.(current \
behavior)
versus:
A user might want to keep a filter while navigating an arbitrary set of folders, but \
is unable to, since the filter is automatically cleared upon navigation
The implementation to try to resolve this conflict is as follows:
1. A lock filter toggle button is added to the right side of the filter bar.
2. If the lock filter button is clicked(on), then if the user navigates away from the \
current folder, the filter is not cleared. If the lock filter button is \
released(off), then the text is cleared on navigation...which is the current \
behavior. 3. A configurable shortcut is added to toggle the lock filter button, with \
the default being Ctrl-Shift-I (since the default shortcut for hiding and showing the \
filter bar is Ctrl-I.) 4. If the user toggles the lock filter button to released \
(off), then the text in the filter also clears. The assumption here is that if the \
user no longer wants the text to be locked, he probably also wants to clear the text. \
5. When the filter bar is hidden, then the lock filter button is released. The next \
time the filter bar is shown, the lock filter button will be in the released(off) \
position and the filter text will have been cleared. 6. At application startup, the \
lock filter button is always off, and the filter bar text cleared.
This also fixes a current bug in dolphin where one is unable to toggle the visibility \
of the filter bar using the tool bar filter button, or by using the assigned hot key.
Note... I think it is 'patch -p2' from the "dolphin" directory \
(above src directory ) to apply the patch</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Went through all paths in dolphin. Tested: 1. Navigate to different \
folder. Text should clear only when text not locked 2.Ctl-I shortcut to toggle \
visiblility of filterbar 3.Text clears when filterbar hidden and then shown
4. Lock button locks and unlocks text
5. Shift-Ctl-I shortcut to toggle lock status of text. Lock button updates \
appropriately 6. Status (with non-perisistence from previous instance) of lock button \
when starting application..i.e. lock status is off on startup 7. Change keyboard \
shortcuts...works appropriately 8. F3 and split view..tabs..etc.. should still work \
appropriately 9. Monkey tested...cannot get it to crash
etc....</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7da5801)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(11e03d0)</span></li>
<li>dolphin/src/dolphinviewcontainer.h <span style="color: \
grey">(0300273)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(6e99437)</span></li>
<li>dolphin/src/filterbar/filterbar.h <span style="color: \
grey">(9546c63)</span></li>
<li>dolphin/src/filterbar/filterbar.cpp <span style="color: \
grey">(f3076f0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107392/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic