From kfm-devel Sat Nov 10 17:26:26 2012 From: "Emmanuel Pescosta" Date: Sat, 10 Nov 2012 17:26:26 +0000 To: kfm-devel Subject: Re: Review Request: Fix Bug 304643 - selected place looks ugly and incomplete Message-Id: <20121110172626.27836.57794 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=135256841021458 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6084698739040793169==" --===============6084698739040793169== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 10, 2012, 4:24 p.m., Nuno Bento wrote: > > Hey there! I believe Frank meant Nuno Pinheiro, not me. :) > > = > > But if I may, I'd like to chime in and say that I personally think the = patched version looks better. Oh sorry ... but thanks for your reply ;) Hmm I can't find Nuno Pinheiro on reviewboard?? - Emmanuel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106827/#review21776 ----------------------------------------------------------- On Nov. 9, 2012, 9:55 p.m., Emmanuel Pescosta wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106827/ > ----------------------------------------------------------- > = > (Updated Nov. 9, 2012, 9:55 p.m.) > = > = > Review request for Dolphin, Frank Reininghaus and Nuno Bento. > = > = > Description > ------- > = > Fix Bug 304643 - selected place looks ugly and incomplete > = > = > This addresses bug 304643. > http://bugs.kde.org/show_bug.cgi?id=3D304643 > = > = > Diffs > ----- > = > dolphin/src/kitemviews/kitemlistwidget.h 55181fa = > dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a = > dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d = > dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf = > dolphin/src/panels/folders/foldersitemlistwidget.cpp b4f9a5b = > dolphin/src/panels/places/placesitemlistwidget.h a2a88c1 = > dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da = > = > Diff: http://git.reviewboard.kde.org/r/106827/diff/ > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > Old and new Dolphin Places look > http://git.reviewboard.kde.org/r/106827/s/779/ > = > = > Thanks, > = > Emmanuel Pescosta > = > --===============6084698739040793169== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106827/

On November 10th, 2012, 4:24 p.m., Nuno Ben= to wrote:

Hey there=
! I believe Frank meant Nuno Pinheiro, not me. :)

But if I may, I'd like to chime in and say that I personally think the =
patched version looks better.
Oh sorry ..=
. but thanks for your reply ;)

Hmm I can't find Nuno Pinheiro on reviewboard??

- Emmanuel


On November 9th, 2012, 9:55 p.m., Emmanuel Pescosta wrote:

Review request for Dolphin, Frank Reininghaus and Nuno Bento.
By Emmanuel Pescosta.

Updated Nov. 9, 2012, 9:55 p.m.

Descripti= on 

Fix Bug 304643 - selected place looks ugly and incomplete
Bugs: 304643

Diffs=

  • dolphin/src/kitemviews/kitemlistwidget.h (= 55181fa)
  • dolphin/src/kitemviews/kitemlistwidget.cpp (6a7111a)
  • dolphin/src/kitemviews/kstandarditemlistwidget.h (787722d)
  • dolphin/src/kitemviews/kstandarditemlistwidget.cpp (72d10cf)
  • dolphin/src/panels/folders/foldersitemlistwidget.cpp (b4f9a5b)
  • dolphin/src/panels/places/placesitemlistwidget.h (a2a88c1)
  • dolphin/src/panels/places/placesitemlistwidget.cpp (e33d1da)

View Diff

Screensho= ts

3D"Old
--===============6084698739040793169==--