[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Review Request: Fix Bug 153984 - Clicking cancel on the authentication dialog for fish/sftp/ftp kios
From:       "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date:       2012-10-29 15:12:50
Message-ID: 20121029151250.2700.83980 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107116/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.


Description
-------

Fix Bug 153984 - Clicking cancel on the authentication dialog for fish/sftp/ftp kioslave gets \
dolphin stuck on "Loading folder"


This addresses bug 153984.
    http://bugs.kde.org/show_bug.cgi?id=153984


Diffs
-----

  dolphin/src/dolphinviewcontainer.h 8a0309b 
  dolphin/src/dolphinviewcontainer.cpp 8a566cf 
  dolphin/src/kitemviews/kfileitemmodel.h 5bcebce 
  dolphin/src/kitemviews/kfileitemmodel.cpp 61f512a 
  dolphin/src/views/dolphinview.h 7d8e8b7 
  dolphin/src/views/dolphinview.cpp 9051d98 

Diff: http://git.reviewboard.kde.org/r/107116/diff/


Testing
-------

Works with sftp, ftp and fish.

When you press cancel, the progressbar disappears and the status message "Directory loading has \
been canceled." is displayed.


Thanks,

Emmanuel Pescosta


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107116/">http://git.reviewboard.kde.org/r/107116/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix Bug 153984 - \
Clicking cancel on the authentication dialog for fish/sftp/ftp kioslave gets dolphin stuck on \
&quot;Loading folder&quot;</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works with sftp, ftp \
and fish.

When you press cancel, the progressbar disappears and the status message &quot;Directory \
loading has been canceled.&quot; is displayed.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=153984">153984</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/dolphinviewcontainer.h <span style="color: grey">(8a0309b)</span></li>

 <li>dolphin/src/dolphinviewcontainer.cpp <span style="color: grey">(8a566cf)</span></li>

 <li>dolphin/src/kitemviews/kfileitemmodel.h <span style="color: grey">(5bcebce)</span></li>

 <li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: grey">(61f512a)</span></li>

 <li>dolphin/src/views/dolphinview.h <span style="color: grey">(7d8e8b7)</span></li>

 <li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(9051d98)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107116/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic