[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Implemented multithreading in KFileItemModelSortAlgorithm
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2012-10-29 7:34:22
Message-ID: 20121029073422.18093.53555 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 28, 2012, 7:49 p.m., Mark Gaiser wrote:
> > I just saw one issue in the code that you probably forget to update.
> > The KFileItemModelSortAlgorithm::sequentialSort function has calls to "=
sort". That used to be fine, but the sort function is now following the par=
allelSort path. I think you have to change the two "sort" calls in KFileIte=
mModelSortAlgorithm::sequentialSort to "sequentialSort". Right now everythi=
ng ends up using parallelSort unless i'm reading it wrong..
> =
> Emmanuel Pescosta wrote:
> Oh ... Yes you are right ... I will fix it ;)
> =
> Emmanuel Pescosta wrote:
> Am I allowed to push the small change without review request?
> =
> Old:
> =
> sort(model, begin, middle);
> sort(model, middle, end);
> =
> New:
> =
> sequentialSort(model, begin, middle);
> sequentialSort(model, middle, end);
> =
> Mark Gaiser wrote:
> I would say yes, but i'm not the dolphin maintainer. Wait till Frank =
comes by again and gives you another ship it.
Good catch! It is so obvious that this makes sense (even though we've all m=
issed it, hehe) that I'd say that you could have even pushed it without ask=
ing. Thanks!
- Frank
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107025/#review21058
-----------------------------------------------------------
On Oct. 26, 2012, 7:17 p.m., Emmanuel Pescosta wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107025/
> -----------------------------------------------------------
> =
> (Updated Oct. 26, 2012, 7:17 p.m.)
> =
> =
> Review request for Dolphin and Frank Reininghaus.
> =
> =
> Description
> -------
> =
> Implemented multithreading in KFileItemModelSortAlgorithm.
> =
> If more than 100 items to sort and ideal thread count is greater than 1 -=
> sort them with parallelSort (2 Threads)
> =
> Use maximal 2 Threads, because more than 2 Threads are "slower" (more ove=
rhead than speed up). (I also have a patch which uses n Threads for sorting=
, if you want test it ;)
> =
> =
> Diffs
> -----
> =
> dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 3a596df =
> dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp e0aac13 =
> =
> Diff: http://git.reviewboard.kde.org/r/107025/diff/
> =
> =
> Testing
> -------
> =
> About 2 seconds faster with sorting 500.000 files.
> About 5 seconds faster with sorting 1.000.000 files.
> =
> =
> Thanks,
> =
> Emmanuel Pescosta
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107025/">http://git.reviewboard.kde.org/r/107025/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 28th, 2012, 7:49 p.m., <b>Mark \
Gaiser</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I just saw one issue in the code that you probably forget to update. The \
KFileItemModelSortAlgorithm::sequentialSort function has calls to "sort". \
That used to be fine, but the sort function is now following the parallelSort path. I \
think you have to change the two "sort" calls in \
KFileItemModelSortAlgorithm::sequentialSort to "sequentialSort". Right now \
everything ends up using parallelSort unless i'm reading it wrong..</pre> \
</blockquote>
<p>On October 28th, 2012, 7:54 p.m., <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh ... Yes you are right \
... I will fix it ;)</pre> </blockquote>
<p>On October 28th, 2012, 8:03 p.m., <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Am I allowed to push the \
small change without review request?
Old:
sort(model, begin, middle);
sort(model, middle, end);
New:
sequentialSort(model, begin, middle);
sequentialSort(model, middle, end);</pre>
</blockquote>
<p>On October 28th, 2012, 8:16 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would say yes, but \
i'm not the dolphin maintainer. Wait till Frank comes by again and gives you \
another ship it.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good catch! It is so \
obvious that this makes sense (even though we've all missed it, hehe) that \
I'd say that you could have even pushed it without asking. Thanks!</pre> <br />
<p>- Frank</p>
<br />
<p>On October 26th, 2012, 7:17 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2012, 7:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implemented multithreading in KFileItemModelSortAlgorithm.
If more than 100 items to sort and ideal thread count is greater than 1 -> sort \
them with parallelSort (2 Threads)
Use maximal 2 Threads, because more than 2 Threads are "slower" (more \
overhead than speed up). (I also have a patch which uses n Threads for sorting, if \
you want test it ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">About 2 seconds faster with sorting 500.000 files. About 5 seconds \
faster with sorting 1.000.000 files.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h <span style="color: \
grey">(3a596df)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp <span \
style="color: grey">(e0aac13)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107025/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic