[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Implemented multithreading in KFileItemModelSortAlgorithm
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2012-10-25 18:26:55
Message-ID: 20121025182655.920.92340 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107025/#review20910
-----------------------------------------------------------
dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp
<http://git.reviewboard.kde.org/r/107025/#comment16473>
(span > 100) is useless since you only get in this function if the span=
> 100 requirement is met.
- Mark Gaiser
On Oct. 25, 2012, 6:05 p.m., Emmanuel Pescosta wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107025/
> -----------------------------------------------------------
> =
> (Updated Oct. 25, 2012, 6:05 p.m.)
> =
> =
> Review request for Dolphin and Frank Reininghaus.
> =
> =
> Description
> -------
> =
> Implemented multithreading in KFileItemModelSortAlgorithm.
> =
> If more than 100 items to sort and ideal thread count is greater than 1 -=
> sort them with parallelSort (2 Threads)
> =
> Use maximal 2 Threads, because more than 2 Threads are "slower" (more ove=
rhead than speed up). (I also have a patch which uses n Threads for sorting=
, if you want test it ;)
> =
> =
> Diffs
> -----
> =
> dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 3a596df =
> dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp e0aac13 =
> =
> Diff: http://git.reviewboard.kde.org/r/107025/diff/
> =
> =
> Testing
> -------
> =
> About 2 seconds faster with sorting 500.000 files.
> About 5 seconds faster with sorting 1.000.000 files.
> =
> =
> Thanks,
> =
> Emmanuel Pescosta
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107025/">http://git.reviewboard.kde.org/r/107025/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107025/diff/4/?file=92354#file92354line68" style="color: \
black; font-weight: bold; text-decoration: \
underline;">dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KFileItemModelSortAlgorithm::parallelSort(KFileItemModel* model,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th> \
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">((</span><span class="n">numberOfThreads</span> <span \
class="o">></span> <span class="mi">1</span><span class="p">)</span> <span \
class="o">&&</span> <span class="p">(</span><span class="n">span</span> <span \
class="o">></span> <span class="mi">100</span><span class="p">))</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(span > 100) is useless since \
you only get in this function if the span > 100 requirement is met.</pre> </div>
<br />
<p>- Mark</p>
<br />
<p>On October 25th, 2012, 6:05 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2012, 6:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implemented \
multithreading in KFileItemModelSortAlgorithm.
If more than 100 items to sort and ideal thread count is greater than 1 -> sort them with \
parallelSort (2 Threads)
Use maximal 2 Threads, because more than 2 Threads are "slower" (more overhead than \
speed up). (I also have a patch which uses n Threads for sorting, if you want test it ;)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">About 2 seconds \
faster with sorting 500.000 files. About 5 seconds faster with sorting 1.000.000 files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h <span style="color: \
grey">(3a596df)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp <span style="color: \
grey">(e0aac13)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107025/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic