[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Make Find a toggle action
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2012-10-23 23:14:40
Message-ID: 20121023231440.21514.93092 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107016/#review20769
-----------------------------------------------------------
I think that was once done to make it consistent with eg. the filter bar wh=
ich also is opened and then has a close button. When it is a toggle action,=
this should make it possible to get rid of that annoying close button in t=
he Find bar? What do you think?
- Kai Uwe Broulik
On Oct. 23, 2012, 10:07 p.m., Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107016/
> -----------------------------------------------------------
> =
> (Updated Oct. 23, 2012, 10:07 p.m.)
> =
> =
> Review request for Dolphin and Frank Osterfeld.
> =
> =
> Description
> -------
> =
> I was working in the placesview when I noticed that the Find is not a tog=
gle button. Pushing many times the Find button resulted in "nothing" and I =
expected it to "disable" the search mode, as it happens with Split, or Prev=
iew.
> =
> The patch is pretty straight forward.
> =
> =
> Diffs
> -----
> =
> dolphin/src/dolphinmainwindow.h 7da5801 =
> dolphin/src/dolphinmainwindow.cpp b4a25a7 =
> =
> Diff: http://git.reviewboard.kde.org/r/107016/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Alex Fiestas
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107016/">http://git.reviewboard.kde.org/r/107016/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that was once \
done to make it consistent with eg. the filter bar which also is opened and then has \
a close button. When it is a toggle action, this should make it possible to get rid \
of that annoying close button in the Find bar? What do you think?</pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On October 23rd, 2012, 10:07 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Osterfeld.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2012, 10:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was working in the placesview when I noticed that the Find is not a \
toggle button. Pushing many times the Find button resulted in "nothing" and \
I expected it to "disable" the search mode, as it happens with Split, or \
Preview.
The patch is pretty straight forward.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7da5801)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(b4a25a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107016/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic