[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Review Request: Make Find a toggle action
From:       "Alex Fiestas" <alex () eyeos ! org>
Date:       2012-10-23 22:07:01
Message-ID: 20121023220701.15780.48625 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107016/
-----------------------------------------------------------

Review request for Dolphin and Frank Osterfeld.


Description
-------

I was working in the placesview when I noticed that the Find is not a toggl=
e button. Pushing many times the Find button resulted in "nothing" and I ex=
pected it to "disable" the search mode, as it happens with Split, or Previe=
w.

The patch is pretty straight forward.


Diffs
-----

  dolphin/src/dolphinmainwindow.h 7da5801 =

  dolphin/src/dolphinmainwindow.cpp b4a25a7 =


Diff: http://git.reviewboard.kde.org/r/107016/diff/


Testing
-------


Thanks,

Alex Fiestas


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107016/">http://git.reviewboard.kde.org/r/107016/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Dolphin and Frank Osterfeld.</div>
<div>By Alex Fiestas.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was working in the \
placesview when I noticed that the Find is not a toggle button. Pushing many times the Find \
button resulted in &quot;nothing&quot; and I expected it to &quot;disable&quot; the search \
mode, as it happens with Split, or Preview.

The patch is pretty straight forward.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7da5801)</span></li>

 <li>dolphin/src/dolphinmainwindow.cpp <span style="color: grey">(b4a25a7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107016/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic