From kfm-devel Fri Oct 19 20:06:45 2012 From: =?utf-8?B?xaF1bXNraQ==?= Date: Fri, 19 Oct 2012 20:06:45 +0000 To: kfm-devel Subject: Re: Review Request: Fix Bug 304643 - selected place looks ugly and incomplete Message-Id: <2141296.qhgcbRMIUd () shumarija> X-MARC-Message: https://marc.info/?l=kfm-devel&m=135067722615847 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart9153758.BOgQTqDdFF" This is a multi-part message in MIME format. --nextPart9153758.BOgQTqDdFF Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday 19 of October 2012 11:50:56 Frank Reininghaus wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106827/ On October 15th, 2012, 3:43 p.m., Frank Reininghaus wrote: First of all, thanks for the patch and the screenshots! It should be added that the "new" look would match the look of KFilePlacesView, i.e., the look of Dolphin's Places Panel in KDE <= 4.8. In particular, it makes sure that the red color of the "Root" place is preserved (the user who reported this considered the color change distracting, and I agree that it can be considered a bit odd). However, when we change this, the behaviour of the Places Panel would be different from the one of the DolphinView. This is most obvious when using Details View. I'm not really sure what the best solution is. There are several options: a) Apply the patch as it is. b) Only remove the color change, and do not extend the selection rectangle. c) Don't change anything. d) Like a), but do the same change in the DolphinView. e) Like b), but do the same change in the DolphinView. I'm not entirely sure what the 'right' approach is, but considering that the wish report did not get much feedback, it's not clear if it's really worth adding extra complexity to implement this. Any other opinions? Do we know how other file managers do it (I don't have any others to test here right now)? On October 17th, 2012, 7:46 p.m., Emmanuel Pescosta wrote: I implemented option d.) So you can decide what looks better, the old or the new Dolphin look. ;) I hope you and the other Dolphin users like it. Thanks for the new patch, Emmanuel! I'm still not quite sure what look is best :-/ I've tried Emmanuel's patch #2 and it looks fine to me. However, it took me some time to actually notice the difference between the current situation and patched dolphin. It probably does look a little better, but i don't use Places panel (and i'm not really convinced it looks better in the DolphinView ), so can't really say --nextPart9153758.BOgQTqDdFF Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

On Friday 19 of October 2012 11:50:56 Frank Reininghaus wrote:

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106827/

On October 15th, 2012, 3:43 p.m., Frank Reininghaus wrote:

First of all, thanks for the patch and the screenshots!

It should be added that the "new" look would match the look of KFilePlacesView, i.e., the look of Dolphin's Places Panel in KDE <= 4.8. In particular, it makes sure that the red color of the "Root" place is preserved (the user who reported this considered the color change distracting, and I agree that it can be considered a bit odd).

However, when we change this, the behaviour of the Places Panel would be different from the one of the DolphinView. This is most obvious when using Details View. I'm not really sure what the best solution is. There are several options:

a) Apply the patch as it is.

b) Only remove the color change, and do not extend the selection rectangle.

c) Don't change anything.

d) Like a), but do the same change in the DolphinView.

e) Like b), but do the same change in the DolphinView.

I'm not entirely sure what the 'right' approach is, but considering that the wish report did not get much feedback, it's not clear if it's really worth adding extra complexity to implement this.

Any other opinions? Do we know how other file managers do it (I don't have any others to test here right now)?

On October 17th, 2012, 7:46 p.m., Emmanuel Pescosta wrote:

I implemented option d.) So you can decide what looks better, the old or the new Dolphin look. ;)

I hope you and the other Dolphin users like it.

Thanks for the new patch, Emmanuel!

I'm still not quite sure what look is best :-/

I've tried Emmanuel's patch #2 and it looks fine to me. However, it took me some time to actually notice the difference between the current situation and patched dolphin. It probably does look a little better, but i don't use Places panel (and i'm not really convinced it looks better in the DolphinView ), so can't really say

--nextPart9153758.BOgQTqDdFF--