[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin
From: "Commit Hook" <null () kde ! org>
Date: 2012-09-26 17:42:17
Message-ID: 20120926174217.13080.48238 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106569/#review19472
-----------------------------------------------------------
This review has been submitted with commit e95e336767ba9c4d761fdb9f356dd6d78ad01c16 \
by Dawit Alemayehu to branch master.
- Commit Hook
On Sept. 26, 2012, 12:53 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106569/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 12:53 p.m.)
>
>
> Review request for Dolphin and KDE Base Apps.
>
>
> Description
> -------
>
> This patch fixes a bug where pressing CTRL+Tab does not switch tabs when active tab \
> in Konqueror is a Dolphin's filemanagement part. It happens because DolphinView \
> installs an event filter and does not call event->ignore() or \
> event->setAccepted(false) to allow those events to be propagated up the event \
> chain.
>
> This addresses bug 302329.
> http://bugs.kde.org/show_bug.cgi?id=302329
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kitemlistview.cpp 54a8cbf
>
> Diff: http://git.reviewboard.kde.org/r/106569/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106569/">http://git.reviewboard.kde.org/r/106569/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e95e336767ba9c4d761fdb9f356dd6d78ad01c16 by Dawit Alemayehu to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On September 26th, 2012, 12:53 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and KDE Base Apps.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2012, 12:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a bug where pressing CTRL+Tab does not switch tabs when \
active tab in Konqueror is a Dolphin's filemanagement part. It happens because \
DolphinView installs an event filter and does not call event->ignore() or \
event->setAccepted(false) to allow those events to be propagated up the event \
chain.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302329">302329</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kitemlistview.cpp <span style="color: \
grey">(54a8cbf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106569/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic