From kfm-devel Thu Aug 30 11:08:34 2012 From: "Vishesh Handa" Date: Thu, 30 Aug 2012 11:08:34 +0000 To: kfm-devel Subject: Review Request: Dolhin Places: Only show file results in Nepomuk Queries Message-Id: <20120830110834.7712.58388 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=134632590121989 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1269751483037300051==" --===============1269751483037300051== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106274/ ----------------------------------------------------------- Review request for Dolphin and Nepomuk. Description ------- Dolphin is a file manager, and shouldn't be concerned with non-file resources like notes, contacts and other stuff. = Use FileQuery instead of Query. = This also results in a faster queries. With File Queries Nepomuk can perform some internal optimizations. PS: I'd like to get this into 4.9.1, so a fast review would be nice. Also, = do we cherry pick or merge KDE/4.9 into master? Diffs ----- dolphin/src/panels/places/placesitemmodel.cpp 4979013 = Diff: http://git.reviewboard.kde.org/r/106274/diff/ Testing ------- Thanks, Vishesh Handa --===============1269751483037300051== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106274/

Review request for Dolphin and Nepomuk.

By Vishesh Handa.

Descripti= on

    Dolphin is a file manager, and shouldn't be concerne=
d with non-file
    resources like notes, contacts and other stuff.
    =

    Use FileQuery instead of Query.
    =

    This also results in a faster queries. With File Queries Nepomuk can
    perform some internal optimizations.

PS: I'd like to get this into 4.9.1, so a fast review would be nice. Al=
so, do we cherry pick or merge KDE/4.9 into master?

Diffs=

dolphin/src/panels/places/placesitemmodel.cpp (4979013)

View Diff

--===============1269751483037300051==--