[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Review Request: Fixes Bugs 242007, 293200 and 305783
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2012-08-30 5:55:45
Message-ID: 20120830055545.13216.85425 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106271/
-----------------------------------------------------------
Review request for Dolphin and Frank Reininghaus.
Description
-------
Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve origin
Fixes Bug 242007 - "Open Folder during Drag operation" cannot go into \
different partition using "Places Pane
Fixes Bug 305783 - dragging a file over a directory
does not expand the dir => Bug discovered: When you drag a
item onto a folder-view-item and then move it away
instantly before the autoactivation event is triggered
(After 750ms), the folder will be opened anyway.
This addresses bugs 242007, 293200 and 305783.
http://bugs.kde.org/show_bug.cgi?id=242007
http://bugs.kde.org/show_bug.cgi?id=293200
http://bugs.kde.org/show_bug.cgi?id=305783
Diffs
-----
dolphin/src/dolphinmainwindow.h ab79fb0
dolphin/src/dolphinmainwindow.cpp d83c9de
dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f
dolphin/src/panels/folders/folderspanel.h 14d8e87
dolphin/src/panels/folders/folderspanel.cpp 0760200
dolphin/src/panels/panel.h 064e1f3
dolphin/src/panels/panel.cpp c2681ec
dolphin/src/panels/places/placespanel.h 8a84e00
dolphin/src/panels/places/placespanel.cpp d445088
Diff: http://git.reviewboard.kde.org/r/106271/diff/
Testing
-------
Thanks,
Emmanuel Pescosta
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106271/">http://git.reviewboard.kde.org/r/106271/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes Bug 293200 - Drag&drop files in dolphin doesnt \
preserve origin
Fixes Bug 242007 - "Open Folder during Drag operation" cannot go \
into different partition using "Places Pane
Fixes Bug 305783 - dragging a file over a directory
does not expand the dir => Bug discovered: When you drag a
item onto a folder-view-item and then move it away
instantly before the autoactivation event is triggered
(After 750ms), the folder will be opened anyway.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=242007">242007</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=293200">293200</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=305783">305783</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: \
grey">(ab79fb0)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(d83c9de)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.cpp <span style="color: \
grey">(88f5d9f)</span></li>
<li>dolphin/src/panels/folders/folderspanel.h <span style="color: \
grey">(14d8e87)</span></li>
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(0760200)</span></li>
<li>dolphin/src/panels/panel.h <span style="color: \
grey">(064e1f3)</span></li>
<li>dolphin/src/panels/panel.cpp <span style="color: \
grey">(c2681ec)</span></li>
<li>dolphin/src/panels/places/placespanel.h <span style="color: \
grey">(8a84e00)</span></li>
<li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(d445088)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106271/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic