[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Dolphin: make --select scroll to the item need to be selected
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-27 18:01:31
Message-ID: 20120827180131.19958.22087 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106209/#review18122
-----------------------------------------------------------
This review has been submitted with commit 282ecb3828117a046b208fc6e2d85c0a=
c2657083 by Weng Xuetian to branch KDE/4.9.
- Commit Hook
On Aug. 26, 2012, 7:37 p.m., Xuetian Weng wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106209/
> -----------------------------------------------------------
> =
> (Updated Aug. 26, 2012, 7:37 p.m.)
> =
> =
> Review request for Dolphin and Frank Reininghaus.
> =
> =
> Description
> -------
> =
> dolphin and konqueror provides "--select" to select items in arguments, b=
ut its not very useful since it doesn't scroll to the corresponding item. T=
his patch is supposed to fix this problem.
> =
> =
> Diffs
> -----
> =
> dolphin/src/dolphinpart.cpp d1626e5 =
> dolphin/src/views/dolphinview.h 1ad4d6c =
> dolphin/src/views/dolphinview.cpp 233c700 =
> =
> Diff: http://git.reviewboard.kde.org/r/106209/diff/
> =
> =
> Testing
> -------
> =
> No problem here and work as expected.
> =
> =
> Thanks,
> =
> Xuetian Weng
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106209/">http://git.reviewboard.kde.org/r/106209/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 282ecb3828117a046b208fc6e2d85c0ac2657083 by Weng Xuetian to \
branch KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 26th, 2012, 7:37 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">dolphin and konqueror provides "--select" to select items in \
arguments, but its not very useful since it doesn't scroll to the corresponding \
item. This patch is supposed to fix this problem.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No problem here and work as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinpart.cpp <span style="color: grey">(d1626e5)</span></li>
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(1ad4d6c)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(233c700)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106209/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic