[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Adjust to Ark's new drag'n'drop D-Bus interface
From: "Raphael Kubo da Costa" <rakuco () freebsd ! org>
Date: 2012-08-23 15:53:12
Message-ID: 20120823155312.534.86149 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106131/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 3:53 p.m.)
Review request for Dolphin and Frank Reininghaus.
Changes
-------
Use QDBusMessage instead of relying on the interface XML installed by Ark.
Description
-------
Ark's drag'n'drop D-Bus interface needs to be changed: so far, the object path was always /DndExtract, \
but this does not work if Ark is being used as an embedded KPart (in Konqueror or Rekonq, for example), \
as all tabs will end up calling QDBusConnection::registerObject() with the same path. Only the first call \
will work, and the result is that dragging and dropping from any tab previewing an archive with Ark will \
extract from the first archive being previewed.
To fix that, applications that accept the application/x-kde-dndextract mimetype should now be adjusted to \
check the application/x-kde-ark-dndextract-service and application/x-kde-ark-dndextract-path ones \
instead; the former contains the same service information that used to be passed, while the latter tells \
which object path should be talked to.
This addresses bug 304860.
http://bugs.kde.org/show_bug.cgi?id=304860
Diffs (updated)
-----
dolphin/src/views/draganddrophelper.cpp 45e5076
Diff: http://git.reviewboard.kde.org/r/106131/diff/
Testing
-------
Dragging and droppping from embedded Ark to Dolphin works as expected.
Thanks,
Raphael Kubo da Costa
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106131/">http://git.reviewboard.kde.org/r/106131/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2012, 3:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use QDBusMessage instead of relying on the \
interface XML installed by Ark.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ark's drag'n'drop D-Bus \
interface needs to be changed: so far, the object path was always /DndExtract, but this does not work if \
Ark is being used as an embedded KPart (in Konqueror or Rekonq, for example), as all tabs will end up \
calling QDBusConnection::registerObject() with the same path. Only the first call will work, and the \
result is that dragging and dropping from any tab previewing an archive with Ark will extract from the \
first archive being previewed.
To fix that, applications that accept the application/x-kde-dndextract mimetype should now be adjusted to \
check the application/x-kde-ark-dndextract-service and application/x-kde-ark-dndextract-path ones \
instead; the former contains the same service information that used to be passed, while the latter tells \
which object path should be talked to.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dragging and droppping from embedded Ark to \
Dolphin works as expected.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304860">304860</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/draganddrophelper.cpp <span style="color: grey">(45e5076)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106131/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic