[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: show icon size tooltip whe using the slider to adjust icon size
From: Burkhard_Lück <lueck () hube-lueck ! de>
Date: 2012-08-13 8:36:41
Message-ID: 20120813083641.25168.52651 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 12, 2012, 8:48 p.m., Frank Reininghaus wrote:
> > Thanks for the patch, looks good! Please push to master (I think it \
> > can't go into 4.9 due to the string freeze).
branches/stable/l10n-kde4/templates/messages/kde-baseapps/dophin.pot
already has this message:
#: statusbar/dolphinstatusbar.cpp:348
#, kde-format
msgctxt "@info:tooltip"
msgid "Size: 1 pixel"
msgid_plural "Size: %1 pixels"
msgstr[0] ""
msgstr[1] ""
So this can go into 4.9 without breaking string freeze
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105990/#review17279
-----------------------------------------------------------
On Aug. 12, 2012, 8:45 a.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105990/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2012, 8:45 a.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> That tooltip was lost in commit 35c773768c952e06ae91448665a6a2f8e78b1fb0 \
> . This simple patch is just a copy and paste of the lost code snippet.
>
> This addresses bug 292700.
> http://bugs.kde.org/show_bug.cgi?id=292700
>
>
> Diffs
> -----
>
> dolphin/src/settings/viewmodes/viewsettingstab.h 2115da1
> dolphin/src/settings/viewmodes/viewsettingstab.cpp fe043a7
>
> Diff: http://git.reviewboard.kde.org/r/105990/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105990/">http://git.reviewboard.kde.org/r/105990/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On August 12th, 2012, 8:48 \
p.m., <b>Frank Reininghaus</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the \
patch, looks good! Please push to master (I think it can't go into 4.9 \
due to the string freeze).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">branches/stable/l10n-kde4/templates/messages/kde-baseapps/dophin.pot
already has this message:
#: statusbar/dolphinstatusbar.cpp:348
#, kde-format
msgctxt "@info:tooltip"
msgid "Size: 1 pixel"
msgid_plural "Size: %1 pixels"
msgstr[0] ""
msgstr[1] ""
So this can go into 4.9 without breaking string freeze</pre>
<br />
<p>- Burkhard</p>
<br />
<p>On August 12th, 2012, 8:45 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2012, 8:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">That tooltip was lost in commit \
35c773768c952e06ae91448665a6a2f8e78b1fb0 . This simple patch is just a copy \
and paste of the lost code snippet.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=292700">292700</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/settings/viewmodes/viewsettingstab.h <span style="color: \
grey">(2115da1)</span></li>
<li>dolphin/src/settings/viewmodes/viewsettingstab.cpp <span style="color: \
grey">(fe043a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105990/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic