[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Fix for Bug 302624 - The size of the rating stars in icons mode depends on the l
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-07 20:57:17
Message-ID: 20120807205717.1412.64402 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105830/#review17079
-----------------------------------------------------------
This review has been submitted with commit 8e006486d45df6fac09d46eb4afad8beb07d7569 by Frank Reininghaus to branch master.
- Commit Hook
On Aug. 2, 2012, 6:43 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105830/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2012, 6:43 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Fixes the size of the rating stars for short and long file names in icons and compact view mode.
>
>
> This addresses bug 302624.
> http://bugs.kde.org/show_bug.cgi?id=302624
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kstandarditemlistwidget.cpp 9cdb60e
>
> Diff: http://git.reviewboard.kde.org/r/105830/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Fixed and Unfixed Dolphin Version
> http://git.reviewboard.kde.org/r/105830/s/661/
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105830/">http://git.reviewboard.kde.org/r/105830/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
8e006486d45df6fac09d46eb4afad8beb07d7569 by Frank Reininghaus to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 2nd, 2012, 6:43 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2012, 6:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the size of the rating stars for short \
and long file names in icons and compact view mode.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302624">302624</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kstandarditemlistwidget.cpp <span style="color: grey">(9cdb60e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105830/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105830/s/661/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/02/dolphin_rating_stars_fix_400x100.png" \
style="border: 1px black solid;" alt="Fixed and Unfixed Dolphin Version" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic