[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Respect the style's icon sizes
From: "David Faure" <faure () kde ! org>
Date: 2012-07-13 23:01:45
Message-ID: 20120713230145.7940.16454 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105548/#review15820
-----------------------------------------------------------
The problem is that with qt-only widget styles, the KDE settings won't be followed.
To fix that, you could use KIconLoader::global()->currentSize( KIconLoader::Small ) \
instead of the style API (code taken from oxygenstyle.cpp).
[On the other hand I think nowadays the icon size configuration GUI has been moved \
together with the style, so it's clear that one needs oxygen for that? Not sure.]
I'm not really objecting, feel free to commit if you think it's ok that the widget \
style decides, in the end (I guess this issue with the user settings exists in many \
other places).
- David Faure
On July 13, 2012, 11:54 a.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105548/
> -----------------------------------------------------------
>
> (Updated July 13, 2012, 11:54 a.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> KDE allows setting icon sizes, which KDE styles (such as Oxygen) respect. On other \
> platforms (e.g. Mac OS X), the sizes will be taken from the platforms' style.
>
> This addresses bug 301959.
> http://bugs.kde.org/show_bug.cgi?id=301959
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kstandarditemlistview.cpp f4d05dc
>
> Diff: http://git.reviewboard.kde.org/r/105548/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Feck
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105548/">http://git.reviewboard.kde.org/r/105548/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem is that with \
qt-only widget styles, the KDE settings won't be followed. To fix that, you could \
use KIconLoader::global()->currentSize( KIconLoader::Small ) instead of the style \
API (code taken from oxygenstyle.cpp).
[On the other hand I think nowadays the icon size configuration GUI has been moved \
together with the style, so it's clear that one needs oxygen for that? Not sure.]
I'm not really objecting, feel free to commit if you think it's ok that the \
widget style decides, in the end (I guess this issue with the user settings exists in \
many other places).</pre> <br />
<p>- David</p>
<br />
<p>On July 13th, 2012, 11:54 a.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated July 13, 2012, 11:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KDE allows setting icon sizes, which KDE styles (such as Oxygen) \
respect. On other platforms (e.g. Mac OS X), the sizes will be taken from the \
platforms' style. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301959">301959</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kstandarditemlistview.cpp <span style="color: \
grey">(f4d05dc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105548/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic