'Re: Review Request: When adding a folder to places, the parent directories name appears instead of t'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request: When adding a folder to places, the parent directories name appears instead of t
From:       "Daniel Kreuter" <daniel.kreuter85 () googlemail ! com>
Date:       2012-07-08 18:57:58
Message-ID: 20120708185758.14569.32939 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105475/
-----------------------------------------------------------

(Updated July 8, 2012, 6:57 p.m.)


Review request for Dolphin and Christoph Feck.


Description
-------

This change fixes the bug 303157 in dolphin 2.1 where the wrong name for places \
appeared when trying to add the selected folder to my places.


This addresses bug 303157.
    http://bugs.kde.org/show_bug.cgi?id=303157


Diffs
-----

  dolphin/src/dolphincontextmenu.cpp e1913a8 

Diff: http://git.reviewboard.kde.org/r/105475/diff/


Testing
-------

Tested against master.


Thanks,

Daniel Kreuter


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105475/">http://git.reviewboard.kde.org/r/105475/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Dolphin and Christoph Feck.</div>
<div>By Daniel Kreuter.</div>


<p style="color: grey;"><i>Updated July 8, 2012, 6:57 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This change fixes the bug 303157 in dolphin 2.1 where the wrong name for \
places appeared when trying to add the selected folder to my places. </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested against master.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=303157">303157</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(e1913a8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105475/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic