[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Better tab titles in dolphin when in split view mode
From: "Peter Penz" <peter.penz19 () gmail ! com>
Date: 2012-03-18 11:14:16
Message-ID: 20120318111416.1383.89230 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104305/#review11534
-----------------------------------------------------------
Thanks for helping us to improve Dolphin! But as Frank I'm also in doubt wh=
ether this should go in at all:
- The unknown dragging-target is an issue. Due to the feedback on bugs.kde.=
org we know that quite a few people are using the drag-feature on tabs (it =
was broken with Dolphin 2.0 -> not good, but at least we know now that this=
feature is used). Also we know that the "split-view" is enabled per defaul=
t by some people, but until now it seems nobody had a trouble with the miss=
ing tab-title for the second, inactive split-view.
- I personally think this improvement gets a problem as soon as more tabs t=
han 3 or 4 tabs are shown, as the available width of a tab decreases and it=
is impossible to recognize even one path of the tab.
So currently I'd tend to skip this change. Probably you'd like to discuss t=
his topic with other people on forum.kde.org (in the Dolphin forum) to at l=
east find out whether other people have a similar demand for this change or=
probably have some other ideas: E.g. I initially thought that using a more=
subtle color for the inactive view text in the tab might work, but tabs do=
n't seem to support richtext... Also we might think about increasing the mi=
nimum tab-width to bypass the second issue.
- Peter Penz
On March 16, 2012, 5:24 p.m., Paul Walger wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104305/
> -----------------------------------------------------------
> =
> (Updated March 16, 2012, 5:24 p.m.)
> =
> =
> Review request for Dolphin.
> =
> =
> Description
> -------
> =
> Showing both locations in the tab title.
> =
> See <http://forum.kde.org/brainstorm.php#idea99434_page1>
> =
> =
> Diffs
> -----
> =
> dolphin/src/dolphinmainwindow.h c2a548906966c302a4b9183c6142b603cd5e53e=
5 =
> dolphin/src/dolphinmainwindow.cpp 4c551b2c39c83146bfa69a08ae3b2ab696ce8=
bde =
> =
> Diff: http://git.reviewboard.kde.org/r/104305/diff/
> =
> =
> Testing
> -------
> =
> Tested with split view mode as default and opening a new tab and than cha=
nging to split mode.
> =
> =
> Thanks,
> =
> Paul Walger
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104305/">http://git.reviewboard.kde.org/r/104305/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for helping us to \
improve Dolphin! But as Frank I'm also in doubt whether this should go in at all:
- The unknown dragging-target is an issue. Due to the feedback on bugs.kde.org we \
know that quite a few people are using the drag-feature on tabs (it was broken with \
Dolphin 2.0 -> not good, but at least we know now that this feature is used). Also \
we know that the "split-view" is enabled per default by some people, but \
until now it seems nobody had a trouble with the missing tab-title for the second, \
inactive split-view.
- I personally think this improvement gets a problem as soon as more tabs than 3 or 4 \
tabs are shown, as the available width of a tab decreases and it is impossible to \
recognize even one path of the tab.
So currently I'd tend to skip this change. Probably you'd like to discuss \
this topic with other people on forum.kde.org (in the Dolphin forum) to at least find \
out whether other people have a similar demand for this change or probably have some \
other ideas: E.g. I initially thought that using a more subtle color for the inactive \
view text in the tab might work, but tabs don't seem to support richtext... Also \
we might think about increasing the minimum tab-width to bypass the second \
issue.</pre> <br />
<p>- Peter</p>
<br />
<p>On March 16th, 2012, 5:24 p.m., Paul Walger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Paul Walger.</div>
<p style="color: grey;"><i>Updated March 16, 2012, 5:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Showing both locations in the tab title.
See <http://forum.kde.org/brainstorm.php#idea99434_page1></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with split view mode as default and opening a new tab and than \
changing to split mode.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: \
grey">(c2a548906966c302a4b9183c6142b603cd5e53e5)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(4c551b2c39c83146bfa69a08ae3b2ab696ce8bde)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104305/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic