[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Rename KFileItemModel::setExpanded() to KFileItemModel::expandParentItems(), fix
From: "Peter Penz" <peter.penz19 () gmail ! com>
Date: 2012-02-04 19:13:48
Message-ID: 20120204191348.11897.79013 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103865/#review10338
-----------------------------------------------------------
Ship it!
Looks very good, thanks!
- Peter Penz
On Feb. 4, 2012, 1:14 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103865/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2012, 1:14 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> This patch makes the following changes to the function \
> KFileItemModel::setExpanded(const QSet<KUrl>& urls):
> 1. Rename to expandParentItems() and make sure that really only the parents are \
> expanded. This fixes a bug in the Folders Panel: If a folder is activated which is \
> not shown in the panel yet, not only its parents, but also the folder itself is \
> expanded.
> 2. Change the argument from a set of URLs to a single URL. The Folders Panel only \
> calls this function for single URLs anyway, and this permits to simplify the \
> function.
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kfileitemmodel.h ff816c8
> dolphin/src/kitemviews/kfileitemmodel.cpp db9b711
> dolphin/src/panels/folders/folderspanel.cpp 2511d7e
> dolphin/src/tests/kfileitemmodeltest.cpp c3611ef
>
> Diff: http://git.reviewboard.kde.org/r/103865/diff/diff
>
>
> Testing
> -------
>
> Works as expected for me. Unit test added (including a test for \
> https://bugs.kde.org/show_bug.cgi?id=291781, which was about the Folders Panel \
> failing to expand folders whose name contains special characters).
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103865/">http://git.reviewboard.kde.org/r/103865/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks very good, \
thanks!</pre> <br />
<p>- Peter</p>
<br />
<p>On February 4th, 2012, 1:14 p.m., Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2012, 1:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes the following changes to the function \
KFileItemModel::setExpanded(const QSet<KUrl>& urls):
1. Rename to expandParentItems() and make sure that really only the parents are \
expanded. This fixes a bug in the Folders Panel: If a folder is activated which is \
not shown in the panel yet, not only its parents, but also the folder itself is \
expanded.
2. Change the argument from a set of URLs to a single URL. The Folders Panel only \
calls this function for single URLs anyway, and this permits to simplify the \
function.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works as expected for me. Unit test added (including a test for \
https://bugs.kde.org/show_bug.cgi?id=291781, which was about the Folders Panel \
failing to expand folders whose name contains special characters).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kfileitemmodel.h <span style="color: \
grey">(ff816c8)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(db9b711)</span></li>
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(2511d7e)</span></li>
<li>dolphin/src/tests/kfileitemmodeltest.cpp <span style="color: \
grey">(c3611ef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103865/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic