[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: fix the rect passed to kcapacitybar paint method
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-01-14 16:10:12
Message-ID: 20120114161012.8073.38179 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103669/#review9814
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Fiestas
On Jan. 12, 2012, 7:06 p.m., Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103669/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2012, 7:06 p.m.)
>
>
> Review request for Dolphin, kdelibs and Solid.
>
>
> Description
> -------
>
> fixes the rect passed to paint method so that it matches the widget rect and not \
> the event (clip) rect, since the former is what's expected by widget styles.
>
> This addresses bug 290879.
> http://bugs.kde.org/show_bug.cgi?id=290879
>
>
> Diffs
> -----
>
> kdeui/widgets/kcapacitybar.cpp 6e63c3f
>
> Diff: http://git.reviewboard.kde.org/r/103669/diff/diff
>
>
> Testing
> -------
>
> Fixes bug above.
> No regression with other styles.
>
>
> Thanks,
>
> Hugo Pereira Da Costa
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103669/">http://git.reviewboard.kde.org/r/103669/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Alex</p>
<br />
<p>On January 12th, 2012, 7:06 p.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, kdelibs and Solid.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2012, 7:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixes the rect passed to paint method so that it matches the widget rect \
and not the event (clip) rect, since the former is what's expected by widget \
styles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes bug above. No regression with other styles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=290879">290879</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/kcapacitybar.cpp <span style="color: grey">(6e63c3f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103669/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic