[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: kfileplaceeditdialog lineedit too small
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2011-10-06 11:07:05
Message-ID: 20111006110705.5638.70207 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote:
> > Why the setMaxLength?? What if one wants to type in a long URL?
> >
> > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big \
> > icon button makes the dialog quite large?
>
> Greg T wrote:
> indeed, the setmaxLength was stupid
>
> it's quite small on 4.6.5 http://wstaw.org/m/2011/10/05/plasma-desktopF27745.jpg
>
>
>
> David Faure wrote:
> Ah I see, it's the german translation which makes the label longer ("Choose an \
> icon" -> "Wählen Sie ein Symbol aus"), leaving less room for the lineedits.
> Patch 3 looks good, although I can't help but think there's a bug if a set*Width() \
> call takes a height() as value :-) But I'll trust Christoph on this one.
> Peter Penz wrote:
> > Patch 3 looks good, although I can't help but think there's a bug if a
> > set*Width() call takes a height() as value :-) But I'll trust Christoph on this \
> > one.
>
> Using QFontMetrics::averageCharWidth() might be an alternative in comparison to use \
> the height as reference for calculating the width (but probably this has some \
> drawbacks I'm not aware of).
First, averageCharWidth() is slow. It goes through every character to compute the \
average. Second, that average might be skewed when there are broken characters in the \
font.
I'll add a comment why the lineedits width depends on the fonts height.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102751/#review7117
-----------------------------------------------------------
On Oct. 5, 2011, 6:22 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102751/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2011, 6:22 p.m.)
>
>
> Review request for Dolphin and kdelibs.
>
>
> Description
> -------
>
> Hi, this patch sets a minimum size for the widget.
>
>
> This addresses bug 266435.
> http://bugs.kde.org/show_bug.cgi?id=266435
>
>
> Diffs
> -----
>
> kfile/kfileplaceeditdialog.cpp d798b4d
>
> Diff: http://git.reviewboard.kde.org/r/102751/diff/diff
>
>
> Testing
> -------
>
> it's working
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102751/">http://git.reviewboard.kde.org/r/102751/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 5th, 2011, 11:30 a.m., <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Why the setMaxLength?? What if one wants to type in a long URL?
Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big \
icon button makes the dialog quite large?</pre> </blockquote>
<p>On October 5th, 2011, 6:23 p.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">indeed, the setmaxLength \
was stupid
it's quite small on 4.6.5 http://wstaw.org/m/2011/10/05/plasma-desktopF27745.jpg
</pre>
</blockquote>
<p>On October 6th, 2011, 7:52 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah I see, it's the \
german translation which makes the label longer ("Choose an icon" -> \
"Wählen Sie ein Symbol aus"), leaving less room for the lineedits.
Patch 3 looks good, although I can't help but think there's a bug if a \
set*Width() call takes a height() as value :-) But I'll trust Christoph on this \
one.</pre> </blockquote>
<p>On October 6th, 2011, 8:15 a.m., <b>Peter Penz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Patch 3 looks good, \
although I can't help but think there's a bug if a > set*Width() call \
takes a height() as value :-) But I'll trust Christoph on this one.
Using QFontMetrics::averageCharWidth() might be an alternative in comparison to use \
the height as reference for calculating the width (but probably this has some \
drawbacks I'm not aware of).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First, \
averageCharWidth() is slow. It goes through every character to compute the average. \
Second, that average might be skewed when there are broken characters in the font.
I'll add a comment why the lineedits width depends on the fonts height.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On October 5th, 2011, 6:22 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and kdelibs.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2011, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi, this patch sets a minimum size for the widget. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it's working</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=266435">266435</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfileplaceeditdialog.cpp <span style="color: grey">(d798b4d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102751/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic