[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: crash on acid3 test
From:       Maksim Orlovich <mo85 () cornell ! edu>
Date:       2011-07-05 12:30:28
Message-ID: CAOHCnGdpewYzePbASLkDYjBBctkbHq_0QxAf=pbqBAs3sNSa+Q () mail ! gmail ! com
[Download RAW message or body]

Are you sure that dbg is what's NULL? It shouldn't be if debugging is
on, and if debugging is off, the instructions to invoke
changeDebugContext shouldn't be generated in the first place.

On 7/3/11, Martin Koller <kollix@aon.at> wrote:
> Hi,
>
> looking at bug https://bugs.kde.org/show_bug.cgi?id=271476
> I see a crash in kdelibs/kjs/bytecode/machine.cpp.in line 210
> in changeDebugContext() where valgrind found a 0-pointer deref.
>
>     if (d == Enter)
>         dbg->enterContext(exec, body->sourceId(), body->firstLine(), fn,
> args);
>     else
>         dbg->exitContext(exec, body->sourceId(), body->lastLine(), fn);
>
> it seems dbg can be 0 but is not checked here.
>
> Any idea for the correct fix ?
>
> --
> Best regards/Schöne Grüße
>
> Martin
> A: Because it breaks the logical sequence of discussion
> Q: Why is top posting bad?
>
> ()  ascii ribbon campaign - against html e-mail
> /\  www.asciiribbon.org   - against proprietary attachments
>
> Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at
>

[prev in list] [next in list] [prev in thread] [next in thread]