[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Patch: Check if web shortcuts already assigned (for bug 84036)
From:       Dawit A <adawit () kde ! org>
Date:       2010-04-26 15:46:11
Message-ID: 201004261146.11734.adawit () kde ! org
[Download RAW message or body]

On Friday, April 16, 2010 05:26:01 Nikolaus Waxweiler wrote:
> Hello,
> I wrote a patch for bug 84036 some time ago (without realizing it) and
> posted it on ReviewBoard but got no answer. So now I'm linking it here:
> http://reviewboard.kde.org/r/3421/

Cannot review it on reviewboard because it is assigned to the usability group, 
but the patch seems fine to me. The only two issues I have with it is the use 
of "foreach" instead of the namespace safe keyword "Q_FOREACH" and a "!" in 
the message displayed when the shortcut is assigned. Other than that it seems 
okay to me...

Regards,
Dawit A.
[prev in list] [next in list] [prev in thread] [next in thread]