[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Several patches for Solaris builds
From: Alexander Neundorf <neundorf () kde ! org>
Date: 2009-12-23 13:16:49
Message-ID: 200912231416.50016.neundorf () kde ! org
[Download RAW message or body]
On Friday 11 December 2009, Pavel Heimlich, a.k.a. hajma wrote:
> Hi,
>
> the kde-solaris project uses several patches to be able to build KDE4
> with Sun Studio on OpenSolaris. They are needed since the compiler is
> stricter about the C++ standards than gcc.
>
> The below bug reports have the patches attached.
> The patches are being used for several months already, they're very
> simple, but they weren't tested on other platform.
>
> https://bugs.kde.org/show_bug.cgi?id=191750
As I said in another mail, check if this also works if the const-method is
also named "val()" instead of "val_const()", and if it does, go ahead and
commit it.
> https://bugs.kde.org/show_bug.cgi?id=191763
Hmm, that one seems a bit weird to me.
You introduce a globl variable, that's not too good.
Maybe instead add to static variables to these two functions and return them ?
Also, it is declared as a pointer pointing to 0, and then in the function this
is dereferenced. This will probably crash at runtime.
Hpw about something like this: ?
const AtomicString& SVGSVGElement::contentScriptType() const
{
/*static const AtomicString defaultValue("text/ecmascript");
const AtomicString& n = getAttribute(contentScriptTypeAttr);
return n.isNull() ? defaultValue : n;*/
static AtomicString as = "";
ASSERT(false);
return as;
}
> https://bugs.kde.org/show_bug.cgi?id=191764
Looks good I'd say.
> https://bugs.kde.org/show_bug.cgi?id=191789
> https://bugs.kde.org/show_bug.cgi?id=191799
Same as above.
> https://bugs.kde.org/show_bug.cgi?id=191810
Looks good I'd say.
Alex
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic